Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pre-conversion of test case/fixture params where .NET supports it implicitly #3761

Open
stevenaw opened this issue Feb 6, 2021 · 1 comment

Comments

@stevenaw
Copy link
Member

stevenaw commented Feb 6, 2021

NUnit has historically handled and pre-converted some type conversions when passing parameters to test cases/fixtures. These include both native-supported implicit conversions of primitives as per the ECMA spec (ex: int -> long or short -> int) and some special case conversions for ease-of-use (like string -> DateTime). Preconversion of primitives within NUnit of types also implicitly converted by netfx + netcore has also meant some bugs and added complexity:

I think it should be considered to drop this preconversion of NUnit-provided ECMA-defined implicit conversions. This would not include removing ease-of-use custom conversions like string -> DateTime which should make it a relatively transparent change to consumers. One point of discussion is that this preconversion was originally added for Compact Framework, and that removing it could disrupt any CF consumers (if that is still supported)

I'd like to hear some thoughts on this.

@stevenaw
Copy link
Member Author

stevenaw commented Mar 5, 2023

A recent pull request (#4307 ) for a bugfix caused me to think back to this issue.
@nunit/framework-team @nunit/core-team @oznetmaster Is there interest in this issue proceeding or should it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant