Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused repository paths from repositories.config #1860

Merged
merged 2 commits into from Oct 28, 2016

Conversation

zharro
Copy link
Contributor

@zharro zharro commented Oct 24, 2016

Fixes #1827: removed all but NUnitFramework paths.

Copy link
Contributor

@jplebre jplebre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question should this also include all the packages from the other projects in the folder?
more notably NUnitFramework/framework

<repository path="..\src\NUnitEngine\nunit.core.engine\packages.config" />
<repository path="..\src\NUnitEngine\nunit.engine.tests\packages.config" />
<repository path="..\src\NUnitEngine\nunit.engine\packages.config" />
<repository path="..\src\NUnitEngine\nunit.v2.driver.tests\packages.config" />
<repository path="..\src\NUnitFramework\testdata\packages.config" />
<repository path="..\src\NUnitFramework\tests\packages.config" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, is this supposed to be repeated, but with inverted / ? seems a bit odd to me never noticed this before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this file is supposed to be auto-generated, but I think we were trying to be smart after a Linux user complained the Windows \ didn't work and switched them over. I think they got auto-readded back the windows way. @zharro can you remove the duplicates with the Linux slashes? I think if we remove the Windows versions they will just end up getting re-added.

@rprouse
Copy link
Member

rprouse commented Oct 24, 2016

Yes, I think it should include the packages.config in the framework. I am not sure why it wasn't automatically added.

@zharro
Copy link
Contributor Author

zharro commented Oct 28, 2016

Looks like Linux build failed after removing Linux slashes. I'll try to figure out the reason.

@ChrisMaddock
Copy link
Member

@zharro - The test error looks unrelated to your changes.

They're occasionally a little flakey. I've restarted the build, hopefully they'll pass the second time, and we can merge!

@rprouse
Copy link
Member

rprouse commented Oct 28, 2016

All passing now. Looks good, merging. Thanks.

@rprouse rprouse merged commit 6778c39 into nunit:master Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants