If you can’t beat ’em, join ’em

[jnm2]

Fixes #3222. It would be nice to figure out why thread aborting hasn't worked for us on Mono in the last ten years, but I should have excluded Mono in #2023 for my test as well, since it's just a fancier version of:

nunit/src/NUnitFramework/tests/Attributes/TimeoutTests.cs

Lines 65 to 76 in 9f2d8ea

	[Test]
	[Platform(Exclude = "Mono", Reason = "Runner hangs at end when this is run")]
	public void TestTimesOutAndTearDownIsRun()
	{
	TimeoutFixture fixture = new TimeoutFixture();
	TestSuite suite = TestBuilder.MakeFixture(fixture);
	TestMethod testMethod = (TestMethod)TestFinder.Find("InfiniteLoopWith50msTimeout", suite, false);
	ITestResult result = TestBuilder.RunTest(testMethod, fixture);
	Assert.That(result.ResultState, Is.EqualTo(ResultState.Failure));
	Assert.That(result.Message, Does.Contain("50ms"));
	Assert.That(fixture.TearDownWasRun, "TearDown was not run");
	}

nunit/src/NUnitFramework/testdata/TimeoutFixture.cs

Lines 49 to 67 in 9f2d8ea

	[Test, Timeout(50)]
	public void InfiniteLoopWith50msTimeout()
	{
	while (true) { }
	}
	[Test, Timeout(500)]
	public void TimeoutWithMessagePumpShouldAbort()
	{
	// Simulate System.Windows.Forms.Application.Run or .ShowDialog,
	// or System.Windows.Threading.Dispatcher.PushFrame,
	// which block on native calls to WaitMessage or MsgWaitForMultipleObjectsEx.
	while (true)
	WaitMessage();
	}
	[DllImport("user32.dll")]
	private static extern bool WaitMessage();

[CharliePoole]

Funny thing... I just assumed you knew it had been a problem and were ultra-determined to fix it!

Your idea about Mono not supporting multiple thread aborts is worth checking out some time.

[mikkelbu]

LGTM, but cannot kick Azure from this computer.

[jnm2]

@CharliePoole I'd sure like to eventually. @rprouse is waiting for my custom awaitables PR and I'm trying to only do things that get me closer to figuring out where its unexpected thread abort is coming from.

[jnm2]

Funny thing... I just assumed you knew it had been a problem and were ultra-determined to fix it!

Guess what? I was ultra-determined to fix #3095 and in fixing it, I accidentally fixed all these tests too! It's a nice reward for a frustrating and time-consuming search. In addition to learning a few things.