enable nullable for RuntimeFramework #4178
Conversation
| @@ -1,110 +0,0 @@ | |||
| // Source: https://github.com/dotnet/runtime/blob/4c71c6cf112d5cdfe5d39485505f1b2991c6e0d5/src/libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/NullableAttributes.cs | |||
There was a problem hiding this comment.
Thanks for noticing that this could be cleaned up!
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Nullable" Version="1.3.1" PrivateAssets="all" /> |
There was a problem hiding this comment.
Oh, now I understand. We've swapped out our own "shape" and copy for this. I'm unsure what the decision process is for taking on new dependencies, but I do like your inclusion of PrivateAssets here.
@jnm2 I think you did the initial pass in making some things nullable. Can I ask you your thoughts on this?
There was a problem hiding this comment.
note that on "taking on new dependencies", Nullable is a source only package. So it has no effect on downstreams
There was a problem hiding this comment.
Ah, this one confused me. I had to go out to the NuGet package and read the description to understand, "This package does not contain any compiled binaries, but instead adds the attribute classes as C# source code to your project." A note as such in the PR would have been helpful.
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Nullable" Version="1.3.1" PrivateAssets="all" /> |
There was a problem hiding this comment.
Ah, this one confused me. I had to go out to the NuGet package and read the description to understand, "This package does not contain any compiled binaries, but instead adds the attribute classes as C# source code to your project." A note as such in the PR would have been helpful.
No description provided.