Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to verify Assert.Multiple only throws for failures in current scopes #4344

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Add a test to verify Assert.Multiple only throws for failures in current scopes #4344

merged 1 commit into from
Apr 23, 2023

Conversation

stevenaw
Copy link
Member

@stevenaw stevenaw commented Apr 10, 2023 •
edited
Loading

Resolves #4331
Based on the repro from #4264 (comment)

mikkelbu
mikkelbu approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikkelbu mikkelbu merged commit bc6d65b into nunit:master Apr 23, 2023
@stevenaw stevenaw mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing to "Accumulate further failures if any on AssertMultiple instead of throwing"
2 participants
@stevenaw @mikkelbu