Issues/4572 properties comparer #4608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenaw
reviewed
Jan 25, 2024
src/NUnitFramework/framework/Constraints/Comparers/PropertiesComparer.cs
Show resolved
Hide resolved
Member
|
Thanks @manfred-brands ! I tried to do a quick review just now before heading out of town early tomorrow. |
OsirisTerje
approved these changes
Jan 27, 2024
Member
OsirisTerje
left a comment
OsirisTerje
left a comment
There was a problem hiding this comment.
Looks good to me. Good solution!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4572
Fixes #4591
By default behaviour is as per 3.14
A new
UsingPropertiesComparer()can be used as an opt-in.Also fixes when using indexers with the property comparer.
Also fixes nested references.