Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using macos-14 instead of macos-latest for CI #4648

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Mar 3, 2024

github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source

And it's fast

Needed to install NET 6 SDK specifically as only NET 7 and NET 8 come OOTB. Setting CI friendly values for DOTNET_NOLOGO and DOTNET_CLI_TELEMETRY_OPTOUT (true).

Fixes #4649
fixes #4381 (hopefully) as MacOS build is now pretty much as fast as Ubuntu build:

image

@lahma lahma marked this pull request as draft March 3, 2024 07:26
* set CI friendly NO_LOGO and CLI_TELEMETRY_OPTOUT
@lahma lahma marked this pull request as ready for review March 3, 2024 07:36
@stevenaw
Copy link
Member

stevenaw commented Mar 3, 2024

Nice find, thanks @lahma ! Impressive to see the difference in macos timing between this PR and others where it's consistently over 5 minutes.

I'll try and give it a proper look over later today

Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks once again @lahma !

@stevenaw stevenaw merged commit ac561dd into nunit:master Mar 3, 2024
5 checks passed
@lahma lahma deleted the macos-14 branch March 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to using MacOS 14 in GitHub Actions MacOS build really slow for some tests
2 participants