Add early return for Streams Equal comparison when they are empty #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OsirisTerje
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
LGTM
@mithileshz Tip: Note that we require issues for release notes. This is small, but - just for the future :-)
|
@OsirisTerje ah sorry! I'll keep that in mind for next time. Thank you! |
|
@mithileshz No problem :-) We do accept PRs without too. It is just that we like to give credit to those who contribute PRs in the release notes , but we do that through the issues and checks who have done the corresponding PR, using an automated process. So without issues you don't get that honorable mention you do deserve :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the streams are seekable and are empty, we can return they are equal and save the allocation of the byte arrays and the comparisons around them.