Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double negative assertions #72

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Avoid double negative assertions #72

merged 1 commit into from
Mar 20, 2023

Conversation

nunnatsa
Copy link
Owner

Description

Patterns like Expect(boolVal).ShouldNot(Equal(false)) or Expect(boolVal).ShouldNot(BeFalse()), the linter will suggest Expect(boolVal).Should(BeTrue())

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added test case and related test data
  • Update the functional test

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran golangci-lint

Patterns like `Expect(boolVal).ShouldNot(Equal(false))` or
`Expect(boolVal).ShouldNot(BeFalse())`, the linter will
suggest `Expect(boolVal).Should(BeTrue())`
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4468264479

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 82.981%

Totals Coverage Status
Change from base Build 4468004751: 0.5%
Covered Lines: 668
Relevant Lines: 805

💛 - Coveralls

@nunnatsa nunnatsa merged commit 349d18a into main Mar 20, 2023
@nunnatsa nunnatsa deleted the double-neg branch March 20, 2023 12:49
@nunnatsa nunnatsa restored the double-neg branch March 20, 2023 12:51
@nunnatsa nunnatsa deleted the double-neg branch March 20, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants