Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev space #92

Merged
merged 56 commits into from
Apr 30, 2023
Merged

Dev space #92

merged 56 commits into from
Apr 30, 2023

Conversation

nunobrum
Copy link
Owner

Finally merging into master.
Introducing:

  • Client Server
  • Separation of SimCommander into SpiceEditor and SimRunner (Singleton approach).
  • Better support for command line switches
  • Support of other simulators (NGspice)
  • Better documentation

Marc Van Riet and others added 30 commits January 15, 2023 01:04
adding output_folder option to SimCommander so that all created files be placed in one single directory.
Adding a file_cleanup() method that deletes all created files.
…the master branch.

This isn't really needed if we are going to rebase to the master, but, this might not be the case if we cannot assure backward compatibility.

If this is the case, another pypi will be created.
Implementing Singleton class approach in order to support a simulation server and allowing simulating the same netlist with different simulators.

Work in progress... tests and documentation not done.
Implementing Singleton class approach in order to support a simulation server and allowing simulating the same netlist with different simulators.

Work in progress... tests and documentation not done.
Work in progress... tests and documentation not done.
Moving tools to the root of the module
Starting to correct documentation issues (Work in progress..)
LTComplex class used in LTSteps stores the dB unit
Fixed messages on the LTSteps regarding the number of measures read
Improvement on the SimCommander (backwards compatibility)
Improvements on the unittest
Preparing everything for the introduction of the client-server simulation
Enhancement on the SpiceEditor run method.
…rts.

An interface that is receiving remote procedure calls, and the server itself which needs to be a thread.
Simplifying code with the addition of the print_info() function
This allows to have a simulation server machine.
… the Simulator.

Managing of command line switches now supported by the RunTask
Improving Documentation
Moving everythin related with Client Server Implementation to client_server Folder
local_run_task.py is renamed to run_task.py
Renaming threads attribute in SimRunner to sim_tasks
Implementing an iterator on the SimRunner for retrieving the results.
Fixes in all modules
Much better documentation
Going to be released as 4.0
Copy link
Owner Author

@nunobrum nunobrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things still to review

from .sim_batch import SimCommander
from .SpiceEditor import ComponentNotFoundError
from .sim_runner import SimCommander
from PyLTSpice.sim.spice_editor import ComponentNotFoundError
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be changed and remove the prefix

from .sim_batch import SimCommander
import pathlib
from functools import wraps
from PyLTSpice.sim.spice_editor import SpiceEditor
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has also to be changed

PyLTSpice/sim/spice_editor.py Show resolved Hide resolved
"""
Finds returns a Subckt from a library file
Finds returns a Subckt from a library file.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define the return type

make.bat Show resolved Hide resolved
make.bat Outdated Show resolved Hide resolved
Copy link
Owner Author

@nunobrum nunobrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

…ems.

Implementing export functions on the RawRead
Making a command line script for reading raw files.
Transforming the code inside the raw_read into an entry point
Minor document improvements and fixes.
Preparing for 4.0 release
Renaming Trace Class used for .raw reads as TraceRead
Adding iteration capability to Datasets
Correcting logging and printout messages
Moving the raw_write tests to its own test file
@nunobrum nunobrum closed this Apr 30, 2023
@nunobrum nunobrum reopened this Apr 30, 2023
Preparing for 4.0 release
Renaming Trace Class used for .raw reads as TraceRead
Adding iteration capability to Datasets
Correcting logging and printout messages
Moving the raw_write tests to its own test file
@nunobrum nunobrum merged commit 5c99747 into master Apr 30, 2023
@nunobrum nunobrum deleted the dev_space branch April 30, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants