-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev space #92
Conversation
adding output_folder option to SimCommander so that all created files be placed in one single directory. Adding a file_cleanup() method that deletes all created files.
…the master branch. This isn't really needed if we are going to rebase to the master, but, this might not be the case if we cannot assure backward compatibility. If this is the case, another pypi will be created.
Implementing Singleton class approach in order to support a simulation server and allowing simulating the same netlist with different simulators. Work in progress... tests and documentation not done.
Implementing Singleton class approach in order to support a simulation server and allowing simulating the same netlist with different simulators. Work in progress... tests and documentation not done.
Work in progress... tests and documentation not done.
Moving tools to the root of the module Starting to correct documentation issues (Work in progress..)
LTComplex class used in LTSteps stores the dB unit Fixed messages on the LTSteps regarding the number of measures read Improvement on the SimCommander (backwards compatibility) Improvements on the unittest
Preparing everything for the introduction of the client-server simulation
Enhancement on the SpiceEditor run method.
…rts. An interface that is receiving remote procedure calls, and the server itself which needs to be a thread.
Simplifying code with the addition of the print_info() function
This allows to have a simulation server machine.
… the Simulator. Managing of command line switches now supported by the RunTask
Improving Documentation Moving everythin related with Client Server Implementation to client_server Folder local_run_task.py is renamed to run_task.py Renaming threads attribute in SimRunner to sim_tasks
Implementing an iterator on the SimRunner for retrieving the results. Fixes in all modules Much better documentation Going to be released as 4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things still to review
PyLTSpice/sim/sim_analysis.py
Outdated
from .sim_batch import SimCommander | ||
from .SpiceEditor import ComponentNotFoundError | ||
from .sim_runner import SimCommander | ||
from PyLTSpice.sim.spice_editor import ComponentNotFoundError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be changed and remove the prefix
PyLTSpice/sim/sim_stepping.py
Outdated
from .sim_batch import SimCommander | ||
import pathlib | ||
from functools import wraps | ||
from PyLTSpice.sim.spice_editor import SpiceEditor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has also to be changed
""" | ||
Finds returns a Subckt from a library file | ||
Finds returns a Subckt from a library file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
define the return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done
…ems. Implementing export functions on the RawRead Making a command line script for reading raw files. Transforming the code inside the raw_read into an entry point Minor document improvements and fixes.
Preparing for 4.0 release Renaming Trace Class used for .raw reads as TraceRead Adding iteration capability to Datasets Correcting logging and printout messages Moving the raw_write tests to its own test file
Preparing for 4.0 release Renaming Trace Class used for .raw reads as TraceRead Adding iteration capability to Datasets Correcting logging and printout messages Moving the raw_write tests to its own test file
Finally merging into master.
Introducing: