Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency in header's layout and size #1233

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

MaikelChan
Copy link
Contributor

@MaikelChan MaikelChan commented Feb 11, 2024

Hi!

I just fixed some inconsistencies in the header:

  • In mobile version, its height would depend on the height of the dark mode switcher. If the user has the switcher disabled, the header would appear very small on mobile.
  • Dark mode switcher is smaller on desktop mode than on mobile, and compared to the other icons.
  • Dark mode switcher on mobile doesn't have color change on hover, the other buttons have.
  • Clickable area in dark mode switcher is much bigger than the other icons (that's why the height of the header in mobile depended on this button).

@MaikelChan
Copy link
Contributor Author

I also added hover color to the header menu and nested menus, the same as the search and dark mode switcher buttons. They didn't have any reaction to being hovered.

@nunocoracao nunocoracao merged commit e29a3f7 into nunocoracao:dev Feb 12, 2024
2 checks passed
@MaikelChan MaikelChan deleted the header-adjustments branch February 13, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants