fix: delete device token when clear identify

nunofgs · May 13, 2022 · 72f9753 · 72f9753
1 parent 834aca0
commit 72f9753
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/sdk/src/main/java/io/customer/sdk/repository/ProfileRepository.kt b/sdk/src/main/java/io/customer/sdk/repository/ProfileRepository.kt
@@ -72,8 +72,20 @@ class ProfileRepositoryImpl(
     }
 
     override fun clearIdentify() {
-        preferenceRepository.getIdentifier()?.let { identifier ->
-            preferenceRepository.removeIdentifier(identifier)
+        logger.debug("clearing identified profile request made")
+
+        val currentlyIdentifiedProfileId = preferenceRepository.getIdentifier()
+
+        if (currentlyIdentifiedProfileId == null) {
+            logger.info("no profile is currently identified. ignoring request to clear identified profile")
+            return
         }
+
+        // delete token from profile to prevent sending the profile pushes when they are not identified in the SDK.
+        deviceRepository.deleteDeviceToken()
+
+        // delete identified from device storage to not associate future SDK calls to this profile
+        logger.debug("clearing profile from device storage")
+        preferenceRepository.removeIdentifier(currentlyIdentifiedProfileId)
     }
 }
diff --git a/sdk/src/sharedTest/java/io/customer/sdk/repository/ProfileRepositoryTest.kt b/sdk/src/sharedTest/java/io/customer/sdk/repository/ProfileRepositoryTest.kt
@@ -15,6 +15,7 @@ import org.mockito.Mockito.verifyNoInteractions
 import org.mockito.kotlin.anyOrNull
 import org.mockito.kotlin.inOrder
 import org.mockito.kotlin.mock
+import org.mockito.kotlin.never
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.verifyNoMoreInteractions
 import org.mockito.kotlin.whenever
@@ -150,20 +151,22 @@ class ProfileRepositoryTest : BaseTest() {
     // clearIdentify
 
     @Test
-    fun clearIdentify_verifyWhenCustomerIdentifyIsClearedItsRemovedInPrefsRepo() {
+    fun clearIdentify_verifyWhenCustomerIdentifyIsClearedItsRemovedInPrefsRepo_expectDeleteDeviceToken() {
         val givenIdentifier = String.random
         prefRepository.saveIdentifier(givenIdentifier)
 
         repository.clearIdentify()
 
         prefRepository.getIdentifier().shouldBeNull()
+        verify(deviceRepositoryMock).deleteDeviceToken()
     }
 
     @Test
-    fun clearIdentify_givenNoPreviouslyIdentifiedProfile_expectIgnoreRequest() {
+    fun clearIdentify_givenNoPreviouslyIdentifiedProfile_expectIgnoreRequest_expectDontDeleteDeviceToken() {
         repository.clearIdentify()
 
         prefRepository.getIdentifier().shouldBeNull()
+        verify(deviceRepositoryMock, never()).deleteDeviceToken()
     }
 
     // addCustomProfileAttributes