-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing branch aliases #73
Comments
What is your need? Currently the stable is Line 57 in 77dab00
It's not stable yet. |
There are no branch aliases. They are only read from the "default" branch, which is "stable" in this repo. Any config in other branches is totally ignored. There are currently no branch aliases, so v3 or v4 dev versions cannot be installed using composer without having to ask for a branch. |
There are no branch aliases: https://github.com/nunomaduro/collision/blob/stable/composer.json. |
PS You can always check what branch aliases packagist has picked up at https://packagist.org/packages/nunomaduro/collision. |
(compare to https://packagist.org/packages/laravel/framework) |
This statement is incorrect. Anyway, fixed here: bb5d823 |
No 4.x-dev. Is the webhook working? |
What is your end goal? If you perform |
No you won't. That will only happen if Packagist acknowledges the alias. |
Hmmm, something seems to be wrong with Packagist, since it's not displaying the version alias correctly. Compare the collision packagist entry with the one for laravel/framework. Yet, the API still has the branch alias: https://repo.packagist.org/p/nunomaduro/collision%249baf696191ef08d48c30f185315ac00ee371c264ea91df3b75d03e2f0a6e8ce4.json and composer is able to resolve the version as you say. |
Ping @Seldaek. What's going wrong here, in that composer can resolve |
|
👆🏻 Here is an example. Just made |
Yeh, I tried this myself, and it worked:
|
What is unexplained is why the Packagist UI says there is no 4.x-dev. |
|
Don't worry too much about the UI. Thanks for this. |
Well, the API also didn't return the version correctly. Composer seemed to look inside the dev-* stuff for the branch aliases, in a way that it doesn't when installing laravel/framework. Anyway, there is not an issue with this repo. The issue is with Packagist. I'm sure you've done everything right with the branch aliases. |
http://repo.packagist.org/p/laravel/framework%24a7c2cfd6b0b4112fc8c36cbec4fffd6eb3c17cc3aafc5bca3a496a862d3dd87b.json has the 6.x-dev versions explicitly: |
laravel/framework has a 6.x-dev explicitly because it has a 6.x branch.. this repo has dev-next with an alias for 4.x, which is shown at https://packagist.org/packages/nunomaduro/collision#dev-next but it has no 4.x branch so that's not shown as a standalone version. |
true, that looks like a bug |
@GrahamCampbell we both were right after all. |
Fixed now |
@Seldaek Nice. 👍 |
Could you add branch aliases, so composer knows which branches are 2.x, 3.x, and 4.x please?
The text was updated successfully, but these errors were encountered: