-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Artisan command #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to remove 420
lines.
I'm not sure why Scrutinizer tests are failing. |
Just removed the service, we don't use it anyway. |
Scrutinizer on PHP 7.3 is unable to install packages due to unsolvable version constrains https://scrutinizer-ci.com/g/nunomaduro/larastan/inspections/6805790a-6eac-42b7-9474-226f1359cc78/configs |
@szepeviktor Can we get a summary why was this feature removed? |
It had no additional value. |
Also: it did interfered with expectations of how phpstan itself works (this was most notably for users which had an existing phpstan with a config, then added larastan and then it didn't work due to certain environment setup regarding file paths was different => all fixed == gone now) |
No description provided.