Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Artisan command #391

Merged
merged 5 commits into from
Dec 22, 2019
Merged

Removes Artisan command #391

merged 5 commits into from
Dec 22, 2019

Conversation

canvural
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to remove 420 lines.

@canvural
Copy link
Collaborator Author

I'm not sure why Scrutinizer tests are failing.

@nunomaduro nunomaduro merged commit 8aad87d into larastan:master Dec 22, 2019
@nunomaduro
Copy link
Collaborator

Just removed the service, we don't use it anyway.

@szepeviktor
Copy link
Collaborator

szepeviktor commented Dec 22, 2019

Scrutinizer on PHP 7.3 is unable to install packages due to unsolvable version constrains https://scrutinizer-ci.com/g/nunomaduro/larastan/inspections/6805790a-6eac-42b7-9474-226f1359cc78/configs

@gazben
Copy link

gazben commented Feb 24, 2020

@szepeviktor Can we get a summary why was this feature removed?

@canvural canvural deleted the remove-artisan-command branch February 24, 2020 14:31
@szepeviktor
Copy link
Collaborator

It had no additional value.
It had started PHPStan with a simple config file.
Now you have to create that file: https://github.com/nunomaduro/larastan/blob/master/README.md#-getting-started-in-3-steps

@mfn
Copy link
Contributor

mfn commented Feb 24, 2020

Also: it did interfered with expectations of how phpstan itself works (this was most notably for users which had an existing phpstan with a config, then added larastan and then it didn't work due to certain environment setup regarding file paths was different => all fixed == gone now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants