fix: fixes query builder methods within custom builders #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertvanHoekelen
approved these changes
Feb 5, 2020
szepeviktor
reviewed
Feb 5, 2020
| * @param string[] $categories | ||
| * | ||
| * @return CustomBuilder | ||
| * @phpstan-return CustomBuilder<TModelClass> |
There was a problem hiding this comment.
I think other phpdoc parsing softwares understand CustomBuilder<TModelClass>
There was a problem hiding this comment.
PHPStorm was complaining about it for me.
There was a problem hiding this comment.
I see. Generics! https://plugins.jetbrains.com/plugin/12754-php-generics
There was a problem hiding this comment.
Oh, cool. But I don't want to install a plugin for that. PHPStorm will eventually support it.
szepeviktor
reviewed
Feb 5, 2020
nunomaduro
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352
Calling query builder methods inside the custom builder classes wasn't returning the generic builder. This PR fixes that.