New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dynamic wheres can have a mixed parameter #482
Conversation
7c5b213
to
51b6afa
Compare
10b6df0
to
724059d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thank you for the PR! I knew this issue was existing but didn't come around to fix it.
cd8671b
to
9b2cd60
Compare
@canvural are you able to pass an object/array to a dynamic where? Not sure if we can get more specific than |
mixed is okay. We just need to mark it as variadic by passing true as last argument. |
done 👍 |
Can you also add a test case for multiple arguments? |
Oh, sorry. Now I see it. I guess Github showed me the old changes. Now I also see the tests are at Now I also see the tests are at |
9b2cd60
to
201a7bf
Compare
@canvural done |
201a7bf
to
304edc0
Compare
fixes #475
I'm not sure if I've implemented this properly, but the test passes.
Basically the parameter should be a mixed type, instead of just
array
whendynamicWhere
is invoked via theForwardsCalls
trait on the model