Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoUnnecessaryCollectionCallRule when query result is mixed #546

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix NoUnnecessaryCollectionCallRule when query result is mixed #546

merged 1 commit into from
Apr 27, 2020

Conversation

Daanra
Copy link
Contributor

@Daanra Daanra commented Apr 27, 2020

Ensures the rule is only applied when we are certain that we have a collection.

Fixes false positives when the result of a query is inferred as mixed instead of Builder.

@szepeviktor szepeviktor merged commit d20d2eb into larastan:master Apr 27, 2020
@szepeviktor
Copy link
Collaborator

Thank you @Daanra

@nunomaduro
Copy link
Collaborator

nunomaduro commented Apr 28, 2020 •
edited by szepeviktor
Loading

@szepeviktor @Daanra Can you send a pull request or commit directly an new entry under the unreleased to the changelog?

@Daanra Daanra mentioned this pull request Apr 28, 2020
Closed
@canvural
Copy link
Collaborator

canvural commented Apr 28, 2020 •
edited
Loading

I updated the changelog and released 0.5.7 👍 Thanks @Daanra for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szepeviktor szepeviktor szepeviktor approved these changes

@nunomaduro nunomaduro nunomaduro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daanra @szepeviktor @nunomaduro @canvural