Type Hint WhereNotBetween

[amberlampsio]

Resolves issue,

Parameter #2 $values of method Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model>::whereNotBetween() expects array<string, mixed>, array<int, string> given.

Changes

Type hint "int" for whereNotBetween methods

Breaking changes

No Breaking changes

[szepeviktor]

Thank you.
Could you take a look at the tests?

[amberlampsio]

@szepeviktor I am unable to retrigger tests on this PR -- perhaps you can? I'm not sure why this is failing either

[szepeviktor]

Done ⚙️

[szepeviktor]

How does PHPUnit's parseTestMethodAnnotations comes here?

[amberlampsio]

How does PHPUnit's parseTestMethodAnnotations comes here?

I have no idea -- I'm investigating now, perhaps its the github actions matrix

Locally it's 👌

[amberlampsio]

How does PHPUnit's parseTestMethodAnnotations comes here?

So its a conflict in Laravel 6.x, OrchestraBench 4.12.1

[amberlampsio]

@szepeviktor so I added a placeholder method into ApplicationResolver -- seems to solve the issue or we can try to filter out this specific version of Testbench

[szepeviktor]

Thank you :)

[canvural]

Hi,

Thank you for the PR! Can you also add a test for whereNotBetween with integer keyed array?

[amberlampsio]

@szepeviktor I removed the parseTestMethodAnnotations method post update from testbench
@canvural Tests added 👍

[szepeviktor]

• Locking orchestra/testbench (v4.12.2)
• Locking orchestra/testbench-core (v4.11.1)

🎉

[canvural]

Thank you!