ErrorException : sprintf(): Too few arguments

[dmason30]

ErrorException : sprintf(): Too few arguments
.../vendor/nunomaduro/laravel-mojito/src/ViewAssertion.php:168
.../vendor/nunomaduro/laravel-mojito/src/ViewAssertion.php:99

I encountered this error when doing a contains where the expected text has a percentage (%) symbol and does not exist in the html provided. See below test that replicates this issue and currently fails but will pass when the issue has been fixed.

public function testPercentageEscaped()
{
    try {
        (new ViewAssertion('<div>This is a test</div>'))
            ->contains('This text has a percentage 43% symbol');

        $this->assertTrue(false, 'Expected assertion error was not thrown.');
    } catch (AssertionFailedError $e) {
        $this->assertSame(
            "Failed asserting that the text `This text has a percentage 43% symbol` exists within `<div>This is a test</div>`.",
            $e->getMessage()
        );
    }
}

One solution would be to add this str_replace line to the contains method which will escape any percentage symbols. Although it might be better to stop using sprintf in ViewAssertion::assert:

public function contains(string $text): ViewAssertion
{
    $escaped = str_replace('%', '%%', $text);
    self::assert(function () use ($text) {
        Assert::assertStringContainsString((string) $text, $this->html);
    }, "Failed asserting that the text `$escaped` exists within %s.");

    return $this;
}

[SimoTod]

Hi @dmason30, it's a good shout. We are looking into fixing it just now, thanks.
I'll let you know when the new version is released.

[dmason30]

@SimoTod Much appreciated thanks!