Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command will fail on models that contain only properties with inheritdoc comments #65

Closed
hfatahi opened this issue May 16, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@hfatahi
Copy link

hfatahi commented May 16, 2019

Running php artisan insights on a Laravel 5.8 app, I got the following error message
image
The command failed at this file

<?php

namespace App\Models\MasterData;

use App\Models\BaseModel;

class Organization extends BaseModel
{
    /**
     * {@inheritdoc}
     */
    public $timestamps = false;
}

I was able to confirm that:

  • the command will run successfully if I removed the inheritdoc comment.
  • the command will fail only if the model contains no methods, only properties. If the model has one or more methods then the command will run successfully

To reproduce, add the provided model code above to your application and try running the command.

@nunomaduro nunomaduro added the bug Something isn't working label May 16, 2019
@nunomaduro
Copy link
Owner

Thanks for this great description!

@nunomaduro
Copy link
Owner

Can you try with the latest master and re-create a new issue with the same content if you are still having this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants