Prevent failing addNamespace method #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
50bhan
commented
Feb 3, 2020
•
50bhan
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Fixed tickets | #333 #334 |
|
Thanks for this @50bhan 👍 (and @olivernybroe 😉) Could you also add a test on this ? It could be done by launching analyzer on a file with empty namespace and assert no exception is thrown. |
olivernybroe
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Thanks for fixing this bug 👍
I have added a fix for the CI error.
@Jibbarth requesting a review from you also, because I fixed a quick bug in this pr.
|
@Jibbarth Sure, I will add a test and update this PR. |
|
@Jibbarth I added a test. Please check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.