-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing fields for CodeClimate formatter #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's seems ok for me 👍 Thanks @Lootjs
CI Failure not related |
I think some of the confusion is GitLab claims their using CodeClimate but aren't using the full spec. I wonder if it would help to change the current https://github.com/codeclimate/platform/blob/master/spec/analyzers/SPEC.md#data-types they have a very different list of requirements: type -- Required. Must always be "issue". |
Also confirmed working on: GitLab Enterprise Edition 14.4.0-pre |
Actually, I was wrong (see #526 ), there is only "severity" field was missing
https://docs.gitlab.com/ee/user/project/merge_requests/code_quality.html#configuring-jobs-using-variables
Works fine on GitLab Community Edition 13.12.0