Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr/simple-cache ^2.0 and ^3.0 #580

Merged
merged 3 commits into from
May 27, 2022

Conversation

bastien-phi
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Fixed tickets #522 #573

Allows installation of psr/simple-cache in versions ^2.0 and ^3.0

@bastien-phi bastien-phi marked this pull request as draft May 20, 2022 11:34
@bastien-phi bastien-phi force-pushed the allow-psr-simplecache-2-and-3 branch from 47eb956 to e679778 Compare May 20, 2022 11:51
@bastien-phi
Copy link
Contributor Author

I had to exclude psr/simple-cache:^3.0 from symfony:^4.4 build because the composer.json of symfony/cache allows installation of psr/simple-cache:^1.0|^2.0|^3.0 but using version ^3.0 causes LogicException saying that the version of symfony/cache is not compatible with psr/simple-cache:^3.0 (see https://github.com/nunomaduro/phpinsights/runs/6523949630?check_suite_focus=true#step:9:9)

@bastien-phi bastien-phi marked this pull request as ready for review May 20, 2022 11:58
@cmgmyr
Copy link
Collaborator

cmgmyr commented May 26, 2022

I noticed that Laravel 9 wasn't in the test suite, so I added it here: #581. Once my PR is merged, let's make sure this PR runs the updated test suite successfully. cc: @JustSteveKing

@JustSteveKing
Copy link
Collaborator

Good call!

@bastien-phi
Copy link
Contributor Author

@cmgmyr ping me when you PR is merged. I will rebase this one after that

@JustSteveKing
Copy link
Collaborator

@cmgmyr ping me when you PR is merged. I will rebase this one after that

@bastien-phi this is now merged!

@bastien-phi
Copy link
Contributor Author

bastien-phi commented May 27, 2022

AFK, I couldn't rebase from my phone 😅 Hope that a merge is not a problem

@cmgmyr
Copy link
Collaborator

cmgmyr commented May 27, 2022

Thanks @bastien-phi looks great, thanks for the contribution!

@cmgmyr cmgmyr merged commit 4697df8 into nunomaduro:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants