Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add <p> tag support. #89

Merged
merged 2 commits into from
Oct 29, 2021
Merged

feat: Add <p> tag support. #89

merged 2 commits into from
Oct 29, 2021

Conversation

xiCO2k
Copy link
Collaborator

@xiCO2k xiCO2k commented Oct 29, 2021

This PR adds the support for the <p> HTML tag.

Example:

render(<<<'HTML'
    <p>Termwind is such a great tool to style your PHP command-line apps. now we just added the <b>paragraph</b> tag support.</p>
HTML);

Output:

Termwind is such a great tool to style your PHP command-line apps. now we just added the paragraph tag support.

Copy link
Owner

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some tests failing.

@xiCO2k
Copy link
Collaborator Author

xiCO2k commented Oct 29, 2021

Yep looks like a text string is consider a <p> tag with DOMDocument.

I will create an issue to fix that later.

@xiCO2k xiCO2k merged commit bd368c3 into nunomaduro:master Oct 29, 2021
@xiCO2k xiCO2k deleted the add-p-tag branch October 29, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants