Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-ecs): no longer need port override #28

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(aws-ecs): no longer need port override #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion create-an-aws-ecs-byoc-app/components/ecs-service/alb.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module "ingress" {
api = {
name_prefix = "api-"
protocol = "HTTP"
port = 5000
port = 8080
target_type = "ip"
create_attachment = false
health_check = {
Expand Down
6 changes: 3 additions & 3 deletions create-an-aws-ecs-byoc-app/components/ecs-service/service.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ module "service" {
port_mappings = [
{
name = "http"
containerPort = 5000
hostPort = 5000
containerPort = 8080
hostPort = 8080
protocol = "http"
}
]
Expand All @@ -43,7 +43,7 @@ module "service" {
service = {
target_group_arn = module.ingress.target_groups["api"].arn
container_name = "api"
container_port = 5000
container_port = 8080
}
}

Expand Down
Loading