Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Import Microsoft.Common.targets #193

Merged
merged 2 commits into from
Feb 13, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/Authoring.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,17 +155,17 @@ dependency.

For a given a target platform, NuGet will add references to all the libraries in
the corresponding lib folder. You can override this behavior by using the
`Reference` item:
`LibraryReference` item:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference has specific meaning in Microsoft.Common.targtets. I had to rename the item to avoid conflicts.


```xml
<ItemGroup>
<Reference Include="HelloWorld.dll" />
<LibraryReference Include="HelloWorld.dll" />
</ItemGroup>
```

Please note that the reference item doesn't support the `TargetFramework`
Please note that the `LibraryReference` item doesn't support the `TargetFramework`
metadata. Instead, NuGet will only add the references if the file is also
packaged in the corresponding lib folder. If it's not the reference is simply
packaged in the corresponding lib folder. If it's not, the reference is simply
ignored. In other words, the target framework is already controlled by the fact
that the file might or might not be in the corresponding lib folder.

Expand Down
4 changes: 2 additions & 2 deletions src/NuProj.Build/NuProj.Build.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@
<None Include="packages.config" />
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets')" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets')" />
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets'))" />
</Target>
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
Expand Down
2 changes: 1 addition & 1 deletion src/NuProj.Build/packages.config
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Nerdbank.GitVersioning" version="1.1.52-rc" targetFramework="net451" developmentDependency="true" />
<package id="Nerdbank.GitVersioning" version="1.3.13" targetFramework="net451" developmentDependency="true" />
</packages>
4 changes: 2 additions & 2 deletions src/NuProj.Packages/NuProj.Common.nuproj
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ There is also a Visual Studio extension which you find under http://bit.ly/NuPro
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets'))" />
</Target>
<Import Project="..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets')" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets')" />
<Target Name="GetNuPkgVersion" DependsOnTargets="GetBuildVersion">
<PropertyGroup>
<Version>$(NuGetPackageVersion)</Version>
Expand Down
5 changes: 2 additions & 3 deletions src/NuProj.Packages/NuProj.nuproj
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,12 @@ There is also a Visual Studio extension which you find under http://bit.ly/NuPro
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets'))" />
</Target>
<Import Project="..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\NerdBank.GitVersioning.targets')" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\NerdBank.GitVersioning.targets')" />
<Target Name="GetNuPkgVersion" DependsOnTargets="GetBuildVersion">
<PropertyGroup>
<Version>$(NuGetPackageVersion)</Version>
</PropertyGroup>
</Target>

</Project>
4 changes: 2 additions & 2 deletions src/NuProj.ProjectSystem.12/NuProj.ProjectSystem.12.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,12 @@
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<Import Project="ProjectSystem.targets" />
<Import Project="$(VSToolsPath)\VSSDK\Microsoft.VsSDK.targets" Condition="'$(VSToolsPath)' != ''" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets')" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets')" />
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets'))" />
</Target>
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
Expand Down
2 changes: 1 addition & 1 deletion src/NuProj.ProjectSystem.12/packages.config
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Nerdbank.GitVersioning" version="1.1.52-rc" targetFramework="net45" developmentDependency="true" />
<package id="Nerdbank.GitVersioning" version="1.3.13" targetFramework="net45" developmentDependency="true" />
</packages>
4 changes: 2 additions & 2 deletions src/NuProj.ProjectSystem.14/NuProj.ProjectSystem.14.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,11 @@
</PropertyGroup>
<Error Condition="!Exists('..\packages\Microsoft.VisualStudio.ProjectSystem.SDK.Tools.14.0.50721-pre\build\Microsoft.VisualStudio.ProjectSystem.Sdk.Tools.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.VisualStudio.ProjectSystem.SDK.Tools.14.0.50721-pre\build\Microsoft.VisualStudio.ProjectSystem.Sdk.Tools.targets'))" />
<Error Condition="!Exists('..\packages\Microsoft.VisualStudio.SDK.VsixSuppression.14.0.50703\build\Microsoft.VisualStudio.SDK.VsixSuppression.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.VisualStudio.SDK.VsixSuppression.14.0.50703\build\Microsoft.VisualStudio.SDK.VsixSuppression.targets'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets'))" />
</Target>
<Import Project="..\packages\Microsoft.VisualStudio.ProjectSystem.SDK.Tools.14.0.50721-pre\build\Microsoft.VisualStudio.ProjectSystem.Sdk.Tools.targets" Condition="Exists('..\packages\Microsoft.VisualStudio.ProjectSystem.SDK.Tools.14.0.50721-pre\build\Microsoft.VisualStudio.ProjectSystem.Sdk.Tools.targets')" />
<Import Project="..\packages\Microsoft.VisualStudio.SDK.VsixSuppression.14.0.50703\build\Microsoft.VisualStudio.SDK.VsixSuppression.targets" Condition="Exists('..\packages\Microsoft.VisualStudio.SDK.VsixSuppression.14.0.50703\build\Microsoft.VisualStudio.SDK.VsixSuppression.targets')" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.1.52-rc\build\dotnet\Nerdbank.GitVersioning.targets')" />
<Import Project="..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.1.3.13\build\dotnet\Nerdbank.GitVersioning.targets')" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
<Target Name="BeforeBuild">
Expand Down
2 changes: 1 addition & 1 deletion src/NuProj.ProjectSystem.14/packages.config
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<package id="Microsoft.VisualStudio.SDK.VsixSuppression" version="14.0.50703" targetFramework="net451" />
<package id="Microsoft.VisualStudio.Threading" version="14.0.50702" targetFramework="net451" />
<package id="Microsoft.VisualStudio.Validation" version="14.0.50702" targetFramework="net451" />
<package id="Nerdbank.GitVersioning" version="1.1.52-rc" targetFramework="net451" developmentDependency="true" />
<package id="Nerdbank.GitVersioning" version="1.3.13" targetFramework="net451" developmentDependency="true" />
<package id="System.Collections.Immutable" version="1.1.36" targetFramework="net451" />
<package id="System.Reflection.Metadata" version="1.0.21" targetFramework="net451" />
</packages>
5 changes: 3 additions & 2 deletions src/NuProj.Targets/NuProj.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />

<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
Expand Down Expand Up @@ -31,7 +32,7 @@
-->

<PropertyGroup>
<ProjectOutputGroups>
<PackageOutputGroups>
BuiltProjectOutputGroup;
BuiltProjectOutputGroupDependencies;
DebugSymbolsProjectOutputGroup;
Expand All @@ -42,7 +43,7 @@
SatelliteDllsProjectOutputGroupDependencies;
SGenFilesOutputGroup;
SGenFilesOutputGroupDependencies;
</ProjectOutputGroups>
</PackageOutputGroups>
</PropertyGroup>

</Project>