Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DeviceSettings): info alert with a link to the documentation #2020

Merged
merged 10 commits into from
May 17, 2024
Merged

feat(DeviceSettings): info alert with a link to the documentation #2020

merged 10 commits into from
May 17, 2024

Commits on May 11, 2024

  1. feat(DeviceSettings): info alert with a link to the documentation 

    Allows the user to quickly find what are the settings options for.

I personally was looking for what is "Disabled" option actually doing.

The info icon generated using:
* https://getbootstrap.com/docs/5.0/components/alerts/#icons
* https://icons.getbootstrap.com/icons/info-circle-fill/
    @MacDada
    MacDada committed May 11, 2024
    Configuration menu
    Copy the full SHA
    abc0b6e View commit details
    Browse the repository at this point in the history

  2. fix(DeviceSettings): "noreferrer" link

    @MacDada
    MacDada committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ed2d935 View commit details
    Browse the repository at this point in the history

  3. fix(DeviceSettings): fixed code style 

    prettier --check -w "./**/*.{js,jsx,tsx}"
    @MacDada
    MacDada committed May 11, 2024
    Configuration menu
    Copy the full SHA
    4252ac2 View commit details
    Browse the repository at this point in the history

  4. feat(DeviceSettings): styling of docs info alert 

    Centering vertically (perfectionist hell :D)
    @MacDada
    MacDada committed May 11, 2024
    Configuration menu
    Copy the full SHA
    347a372 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. fix(DeviceSettings): docs info alert icon 

    https://github.com/nurikk/zigbee2mqtt-frontend/pull/2020/commits/
abc0b6e#r1599289271
    @MacDada
    MacDada committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2e2272f View commit details
    Browse the repository at this point in the history

  2. style(DeviceSettings): removed unnecessary <div>

    @MacDada
    MacDada committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f9ee9ba View commit details
    Browse the repository at this point in the history

  3. refactor(DeviceSettings): extracted ReadTheDocsInfo 

    fixes https://codebeat.co/projects/github-com-nurikk-zigbee2mqtt-frontend-dev/pull_requests/734366
    @MacDada
    MacDada committed May 14, 2024
    Configuration menu
    Copy the full SHA
    080e707 View commit details
    Browse the repository at this point in the history

  4. refactor(DeviceSettings): extracted ReadTheDocsInfo.tsx 

    fixes https://github.com/nurikk/zigbee2mqtt-frontend/actions/runs/9082086095/job/24957557514?pr=2020
    @MacDada
    MacDada committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5e27780 View commit details
    Browse the repository at this point in the history

  5. style(DeviceSettings): whitespace 

    `prettier --check "./**/*.{js,jsx,tsx}" -w`

fixes https://github.com/nurikk/zigbee2mqtt-frontend/actions/runs/9082225515/job/24958031689

I actually think it's more readable with the code being split into multiply lines…
Not sure why the `prettier` did not like it ;p
    @MacDada
    MacDada committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6994e27 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. fix(ReadTheDocsInfo): i18n 

    fixes https://github.com/nurikk/zigbee2mqtt-frontend/pull/2020/commits/
5e27780#r1604031584
    @MacDada
    MacDada committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0eb757b View commit details
    Browse the repository at this point in the history