Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add onError hook support #152

Closed
5 tasks done
nurrony opened this issue Mar 20, 2024 · 1 comment · Fixed by #156
Closed
5 tasks done

Feature: Add onError hook support #152

nurrony opened this issue Mar 20, 2024 · 1 comment · Fixed by #156

Comments

@nurrony
Copy link
Owner

nurrony commented Mar 20, 2024

What this MR does?

Add hook support for download process like below

const downloader = new HLSDownloader({
  onError: (error) => {
     console.error('error details', error);
  }
})

Error Object Details

// logs
{
  url: "<URLofTheItem>",
  name: "<ErrorName>",
  message: "<HumanReableMessage>",
  total: "<TotalItemToDownload>",
}

Are there points in the code the reviewer needs to double check?

N/a

Why was this MR needed?

Check #147

Dependent MR Link
N/A

Does this MR meet the acceptance criteria?

@nurrony nurrony self-assigned this Mar 20, 2024
@nurrony nurrony mentioned this issue Mar 21, 2024
3 tasks
nurrony added a commit that referenced this issue Mar 22, 2024
it provides information on tracking errors

closes #152
@nurrony nurrony linked a pull request Mar 22, 2024 that will close this issue
4 tasks
nurrony added a commit that referenced this issue Mar 22, 2024
it provides information on tracking errors

closes #152
Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant