Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing onData hook for fetch only items #158

Closed
3 tasks done
nurrony opened this issue Mar 23, 2024 · 1 comment · Fixed by #160
Closed
3 tasks done

fix missing onData hook for fetch only items #158

nurrony opened this issue Mar 23, 2024 · 1 comment · Fixed by #160
Assignees
@nurrony
Labels
bug released

Comments

@nurrony
Copy link
Owner

nurrony commented Mar 23, 2024 •
edited

Prerequisites

  • Can you reproduce the problem in safe mode?
  • Are you running the latest version?
  • Did you perform a cursory search?

Description

fix missing onData hook for fetch only items

Steps to Reproduce

do not pass any path

Expected behavior: [What you expected to happen]

it should log onData

Actual behavior: [What actually happened]

no logs shows
@nurrony nurrony self-assigned this Mar 23, 2024
@nurrony nurrony changed the title fix missing onData and onError hook for fetch only items fix missing onData hook for fetch only items Mar 23, 2024
@nurrony nurrony added the bug label Mar 23, 2024
@nurrony nurrony changed the title fix missing onData hook for fetch only items fix missing onData hook for fetch only items Mar 23, 2024
nurrony added a commit that referenced this issue Mar 23, 2024
@nurrony
fix(downloader): add onData hook for fetch item
159c112 
now fetch items also calls onData hook fine

closes #158
@nurrony nurrony linked a pull request Mar 23, 2024 that will close this issue
fix missing ondata hook for fetch only items #160
Merged
4 tasks
nurrony added a commit that referenced this issue Mar 23, 2024
@nurrony
fix(downloader): add onData hook for fetch item
d9c5fec 
now fetch items also calls onData hook fine

closes #158
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nurrony nurrony

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix missing ondata hook for fetch only items nurrony/hlsdownloader
1 participant
@nurrony