AddressBook - Level1 assignment

[PhilipPhil]

During the tutorial on Wednesday I was able to fork the repository to my github.

I implemented the 3 TODO: tasks. I am not sure what "permissive validation" means. I understood it as we should loosen the requirements and make them less strict for the values to be entered.

I tried to push to my github account but I keep getting an error I do not know how to fix. It says:

git -c diff.mnemonicprefix=false -c core.quotepath=false --no-optional-locks push -v --tags origin master:master
remote: Permission to nus-cs2103-AY1819S2/addressbook-level1.git denied to PhilipPhil.
fatal: unable to access 'https://github.com/nus-cs2103-AY1819S2/addressbook-level1.git/': The requested URL returned error: 403

Pushing to https://github.com/nus-cs2103-AY1819S2/addressbook-level1.git

Completed with errors, see above.

I am not sure what I'm doing wrong.

I also noticed the test folder does not have any JUnit or other testing classes. I'm not sure how we should go about testing the code for this assignment.

[jamessspanggg]

You should try to push to your own forked repo in your GitHub "https://github.com/PhilipPhil/addressbook-level1.git", rather than the original repo in "https://github.com/nus-cs2103-AY1819S2/addressbook-level1.git/".

[jamessspanggg]

Did u cloned from ur forked repo or from the original repo? If you cloned from the original repo you can refer to this link: https://stackoverflow.com/questions/42084116/pushing-to-a-different-git-repo/42084519

[jamessspanggg]

in the project panel, try to right click src -> mark directory as -> Sources root

[PhilipPhil]

I deleted everything and just restarted from scratch. Now the code won't work. I'm not sure what to d

o.

[PhilipPhil]

wait nvm got it to run again. the compiler output was in the wrong folder

[PhilipPhil]

I think I did managed to push TODO's I did. Is there anyway I can check? I'm not sure if i entered the correct email into the start of the mod survey.

[fterh]

You can run git log to check, or look at the commits on Github

[PhilipPhil]

It says I have done 4 commits on github. Does this mean you script knows I have submitted? I'm not sure I gave the correct email in the start of class survey. So I don't know if you can see my commits.

…

On Thu, 24 Jan 2019 at 21:16, Fabian Terh ***@***.***> wrote: You can run git log to check, or look at the commits on Github — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AqvGEk6MnxqzHfe0OVQWLmSNxaGQg9ajks5vGbIVgaJpZM4aQwDg> .

[fterh]

I'm... not a TA so IDK what email you submitted in the survey. I was answering your first part about checking whether you did push your commits successfully (check github). If you want to check what email your commits are made under, you can run git log.

[ccristina]

Hi all,
Regarding the following question/comment we received from multiple students:

I'm not sure I gave the correct email in the start of class survey.

In the survey you only had to input the Github username (no email). You are supposed to use that username for all your PRs for CS2103/T. When you register on Github you are supposed to input an email address.

In case you are not sure that you entered the correct Github username in the survey, don't panic! We will have several checks throughout next week to ensure that we have your correct username.

Best regards,
Cristina.

[roanurquhart]

what should the output folder be?

[okkhoy]

@roanurquhart Can elaborate what output folder you are talking about? Please give the context.
If it makes sense open a new issue

[roanurquhart]

@okkhoy after I opened the cloned repository in IntelliJ I completed this task as suggested by someone earlier to be able to run the program, "right click src -> mark directory as -> Sources root". When I attempted to run it, it said that I was missing a destination for the compiler output. So I created a folder within my local repository called 'out' to handle the compiler output as seen here:

Is this the right thing to do?

[Jackimaru96]

Hello world,

Is there a way to run the test files in the test folder provided in the code after we modify the code?

[fterh]

@Jackimaru96 You can run it in Terminal (sh runtests.sh on Mac/Unix), or the batch file in cmd on Windows.

The real question I have is how to modify the tests :( It's too convoluted... I was expecting unit tests and assertion statements.

[qjqqyy]

@fterh To modify the tests, edit input.txt with the modified/added input cases and change expected.txt to match the new input accordingly.

[okkhoy]

@roanurquhart try: https://www.jetbrains.com/help/idea/specifying-compilation-settings.html
I did not face this problem when I imported afresh. So not sure if the link is the correct solution.

[okkhoy]

@fterh Be careful what you ask for 😈 😜
On a serious note, we will be covering unit tests and you will be writing junit code later in the semester 🙂