[CS2103-T11-3] Powerlifting Competition Coordinator (P.C.C.) #29

ooimingsheng · 2019-09-15T14:46:37Z

…ntation

* Update project website Specifically the AboutUs, ContactUs, and README page. * Edit AboutUs page Changed 'prof' to 'professor' Made changes to responsibilities, and added component ic for everyone.

* Update .gitignore * Enhance RemarkCommand Completed steps up till this step on the tutorial * Add Remark class to the model * Add placeholder element for remark to the UI * Modify Person to support Remark field * Update Storage Add Remark field to JsonAdaptedPerson class * Finalise UI - Connect Remark field to PersonCard * Modify RemarkCommand execute() method

This reverts commit f7d6ca2.

* Change repo url * Update developer guide to include user stories, user profile, non-functional requirements, use cases * Edit repository URL * Edit repository URL to correct URL sorry the previous commit was incorrect

* Made changes to fit team's scope. * Added AddCommands and DeleteCommands. * Added Edit Commands * Added List and View commands. * Corrected repoUrl * Made changes to follow Joshua's implementations. Contains vaguely-implemented methods. * Changed parameters from EntityList to Model. Made some changes to follow Joshua's implementations. * Moved ENTITY_TYPE to a static constant stored in CliSyntax. * Updated code to use viewMinimal() and viewDetailed(). * Minor changes * Implemented potential ways of executing each Participant command. * Merge from upstream * Updated code to use Model#updateParticipant's return value. * Removed Commands associated with Issues. * Removed Commands associated with Issues. (cherry picked from commit cef6975) * Imported Entities and other objects. * Updated AboutUs.adoc and ContactUs.adoc

* Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc * Update UserGuide.adoc

ChangUo79 · 2019-10-03T04:45:40Z

docs/DeveloperGuide.adoc

 * can type fast
 * prefers typing over mouse input
 * is reasonably comfortable using CLI apps

-*Value proposition*: manage contacts faster than a typical mouse/GUI driven app
+*Value proposition*: manage powerlifting competitions faster than a typical mouse/GUI driven app

 [appendix]
 == User Stories


The user story format is correct and the 3 parts are all present. The benefit matches the function nicely. Overall everything is in order and there is no missing user stories. Good job!

ChangUo79 · 2019-10-03T04:48:16Z

docs/DeveloperGuide.adoc

+.  Should come with automated unit tests and open source code.
+.  Should come with a user guide and a developer guide.


These NFRs do not have anything to do with the system and they do not specify the constraints under which system is develeoped and operated.

junhuplim · 2019-10-03T04:41:56Z

docs/DeveloperGuide.adoc

-== Use Cases
+== Use Cases (To Do)
+
+(For all use cases below, the *System* is the `Powerlifting Competition Competitor` and the *Actor* is the `user`, unless specified otherwise)


The use of the term user can be better defined: e.g. athlete/participant

junhuplim · 2019-10-03T04:43:20Z

docs/DeveloperGuide.adoc

+*Extensions*
+
+[none]
+* 2a. The list is empty.


Perhaps your system can show an error message when the list is empty

junhuplim · 2019-10-03T04:45:46Z

docs/DeveloperGuide.adoc

+*MSS*
+
+1. User obtains a list of competitions by listing (<<Use case: UC1 - View my competition list, *UC1*>>)
+2. User requests for a new powerlifting competition to be deleted.


Can cancel the word 'new'

junhuplim · 2019-10-03T04:46:27Z

docs/DeveloperGuide.adoc

+
+1. User obtains a list of competitions by listing (<<Use case: UC1 - View my competition list, *UC1*>>)
+2. User requests for a new powerlifting competition to be deleted.
+3. System adds the new competition to the user's competition list.


Should be delete instead of add

junhuplim · 2019-10-03T04:47:38Z

docs/DeveloperGuide.adoc

+
+*MSS*
+
+1. User obtains a list of competitions by listing (<<Use case: UC1 - View my competition list, *UC1*>>)


Underline the listing with the UC1 since it is referenced. Also, whenever you reference a use case, the same name has to be used

junhuplim · 2019-10-03T04:50:03Z

docs/DeveloperGuide.adoc

+* 2a. System does not find any athletes satisfying all the constraints.
+
+[none]
+** 2a1. System shows an empty list.


Maybe showing an error message would be clearer for the user instead of an empty list

junhuplim · 2019-10-03T04:51:01Z

docs/DeveloperGuide.adoc

+1. User obtains a list of athletes by listing (<<Use case: UC5 - View my athlete list, *UC5*>>).
+or searching (<<Use case: UC6 - Search for athletes,*UC6*>>).
+2. User requests to view more information on a specific athlete in the list.
+3. System shows detailed information of the book.


I think it's athlete instead of book

junhuplim · 2019-10-03T04:54:22Z

docs/DeveloperGuide.adoc

+
+1. User requests for an athlete to be added.
+2. User inputs athlete data.
+3. User confirms that the addition of the athlete cannot be reversed.


Why is this relevant since you can delete a athlete in UC10

* Made changes to fit team's scope. * Added AddCommands and DeleteCommands. * Added Edit Commands * Added List and View commands. * Corrected repoUrl * Made changes to follow Joshua's implementations. Contains vaguely-implemented methods. * Changed parameters from EntityList to Model. Made some changes to follow Joshua's implementations. * Moved ENTITY_TYPE to a static constant stored in CliSyntax. * Updated code to use viewMinimal() and viewDetailed(). * Minor changes * Implemented potential ways of executing each Participant command. * Merge from upstream * Updated code to use Model#updateParticipant's return value. * Removed Commands associated with Issues. * Removed Commands associated with Issues. (cherry picked from commit cef6975) * Imported Entities and other objects. * Updated AboutUs.adoc and ContactUs.adoc

damithc · 2019-10-06T06:57:26Z

Incorrect PR name corrected. Please take note of your correct team ID ...

* Set up models * Remove attempt and participation models

* Update .gitignore to exclude all .iml files * Create Attempt and Participation packages * Remove trailing white spaces in UserGuide.adoc

* Ui.png added to UG * Ui.png added to UG with space * New Ui.png * Delete Ui.png * Add files via upload

* Make generic storage * Add Json classes for participation and competition

* Create ObservableList for the different Attempts * Add Exceptions * Change Attempt, Exercise, Participation classes as well as updated changes to review PR * Optimise imports * Minor changes * Add JavaDoc Comment in Participation.java

* Person class changes propagated Update code to pass checkstyle Fixed customDate equals method Change name from String to Name class Update tests due to changes in Person class * Update src/main/java/seedu/address/model/person/CustomDate.java Co-Authored-By: Christabel <50402053+belbel98@users.noreply.github.com>

…on class (#38) * Refactor participation class * Add participation data storage

For the participation feature

* New Branch * CRUD for Competitions * CRUD added to front end * Remove trailing whitespace from user guide

LGTM

* DG updated * DG updated * removed uml for rank feature * more refinements

* DG updated * DG updated * removed uml for rank feature * more refinements * PPP and DG updated * AddressBook changed to system * diagram changed * AddressBookParser to SystemParser

* Add documentation to developer guide * Add more documentation to the developer guide

#137)

and other minor changes

* Bug Fix Bug fix for starting competition session not in filtered competition list * Fix deleteParticipation result error

ooimingsheng added 3 commits September 14, 2019 23:01

Add notes file to test commit

d960e48

Update ReadMe Build Status badge

0988274

Remove codacy badge to test travis enabling auto-publishing of docume…

de71759

…ntation

ooimingsheng force-pushed the master branch from 42730a1 to de71759 Compare September 15, 2019 16:36

nus-se-pr-bot added tutor.nbriannl tutorial.CS2103-T11 team.3 labels Sep 16, 2019

christabelteo and others added 4 commits September 30, 2019 08:15

Update Project Website (#4)

aae6a55

* Update project website Specifically the AboutUs, ContactUs, and README page. * Edit AboutUs page Changed 'prof' to 'professor' Made changes to responsibilities, and added component ic for everyone.

Revert "Tutorial adding command (#9)" (#10)

d2c2dcf

This reverts commit f7d6ca2.

Edit developer guide (#3)

4699ee0

* Change repo url * Update developer guide to include user stories, user profile, non-functional requirements, use cases * Edit repository URL * Edit repository URL to correct URL sorry the previous commit was incorrect

ChangUo79 reviewed Oct 3, 2019

View reviewed changes

junhuplim reviewed Oct 3, 2019

View reviewed changes

damithc changed the title ~~[CS2103-T08-3] Powerlifting Competition Coordinator (P.C.C.)~~ [CS2103-T11-3] Powerlifting Competition Coordinator (P.C.C.) Oct 6, 2019

shawnkoh and others added 12 commits October 8, 2019 10:05

Set up models (#24)

dc0932d

* Set up models * Remove attempt and participation models

Participation Component (#26)

0ca2f99

* Update .gitignore to exclude all .iml files * Create Attempt and Participation packages * Remove trailing white spaces in UserGuide.adoc

Update user guide (#30)

943b13a

* Ui.png added to UG * Ui.png added to UG with space * New Ui.png * Delete Ui.png * Add files via upload

Abstract out unique lists and exceptions (#32)

4ae810b

Create storage for multiple classes (#34)

8cc6a4b

* Make generic storage * Add Json classes for participation and competition

Refactor participation class and include JSON storage for participati…

bb6d045

…on class (#38) * Refactor participation class * Add participation data storage

Remove unnecessary commands in the User Guide

dd4f1b3

For the participation feature

Update UserGuide.adoc

394da1f

New comp features (#44)

a8f1f51

* New Branch * CRUD for Competitions * CRUD added to front end * Remove trailing whitespace from user guide

Add scoring methods (#45)

54bfd54

HoWeiChin and others added 30 commits November 9, 2019 15:15

Update DeveloperGuide.adoc

f0ab0f1

Update DeveloperGuide.adoc

384f29d

Update DeveloperGuide.adoc

8adcb46

Fix trailing whitespace for travis build

479fbd7

Added session features and sequence diagrams (#126)

b52773f

Make tests (#127)

cd1e1b9

LGTM

Dg (#128)

c0d30d8

* DG updated * DG updated * removed uml for rank feature * more refinements

Add PPP for Ming Sheng

f7e7995

Add search participation and search comp (#123)

6b8c773

Modify user guide, developer guid and PPP (#129)

db05a6c

Dg (#130)

70385af

* DG updated * DG updated * removed uml for rank feature * more refinements * PPP and DG updated * AddressBook changed to system * diagram changed * AddressBookParser to SystemParser

WIP: Update diagrams in developer guide (#131)

501e61d

* Add documentation to developer guide * Add more documentation to the developer guide

Update AboutUs.adoc

f9e0769

Update AboutUs.adoc

eb07e40

Rename HoWeiChin.adoc to howeichin.adoc

771a04a

Update AboutUs.adoc

2dcea24

Update UserGuide.adoc

4bbd545

Modify PPP for Ming (#133)

b9ebaee

User guide, developer guide and project portfolio page (#134)

d843744

Adjust PPP for ming sheng (#135)

99ffc95

Add PPP for Christabel (#136)

4aa0a30

Add documentation for find participation and find competition commands (

57a4f98

#137)

Update Christabel's PPP

51800b2

Fix links on PPP (#138)

126fc1a

Fix tagging issues on Christabel's PPP

3c4dcb1

Merge branch 'master' of https://github.com/AY1920S1-CS2103-T11-3/main

ee92321

Change name to full name

2f8c664

and other minor changes

Delete unnecessary section on DG

802e289

Bug fix on startSession (#139)

34d652d

* Bug Fix Bug fix for starting competition session not in filtered competition list * Fix deleteParticipation result error

Fix bug in ranklist command parser (#140)

f7d21e3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CS2103-T11-3] Powerlifting Competition Coordinator (P.C.C.) #29

[CS2103-T11-3] Powerlifting Competition Coordinator (P.C.C.) #29

ooimingsheng commented Sep 15, 2019

ChangUo79 Oct 3, 2019

ChangUo79 Oct 3, 2019

junhuplim Oct 3, 2019

junhuplim Oct 3, 2019

junhuplim Oct 3, 2019

junhuplim Oct 3, 2019

junhuplim Oct 3, 2019

junhuplim Oct 3, 2019

junhuplim Oct 3, 2019

junhuplim Oct 3, 2019

damithc commented Oct 6, 2019

		. Should come with automated unit tests and open source code.
		. Should come with a user guide and a developer guide.


		MSS

		1. User obtains a list of competitions by listing (<<Use case: UC1 - View my competition list, UC1>>)

[CS2103-T11-3] Powerlifting Competition Coordinator (P.C.C.) #29

Are you sure you want to change the base?

[CS2103-T11-3] Powerlifting Competition Coordinator (P.C.C.) #29

Conversation

ooimingsheng commented Sep 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damithc commented Oct 6, 2019