[Cher Wei Jie] Duke Increments #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)
Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.
Add configuration for console applications
The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.
4 tasks
CharmaineKoh
reviewed
Feb 5, 2020
src/main/java/Task.java
Outdated
| * input will generate. | ||
| */ | ||
| class Task { | ||
| private static String horizontalLine = "__________________________________________"; |
There was a problem hiding this comment.
This variable is not used and it should be removed.
Comment on lines
+49
to
+53
| System.out.println("\n" + "Alright, I've added this task:" + "\n"); | ||
| System.out.println(toDo + "\n"); | ||
| System.out.println("You currently have " | ||
| + tasks.getTaskList().size() | ||
| + " task(s) in the list."); |
There was a problem hiding this comment.
Consider exporting magic strings to another class for neater code.
| ui.showLine(); | ||
| ui.showDoneMessage(); | ||
| doneTask.markAsDone(); | ||
| System.out.println(doneTask + "\n"); |
src/main/java/Parser.java
Outdated
Comment on lines
14
to
32
| if (command.equals("bye")) { | ||
| return new ExitCommand(); | ||
| } else if (command.equals("list")) { | ||
| return new ListCommand(); | ||
| } else if (command.startsWith("done")) { | ||
| String[] arrOfCommands = command.split(" "); | ||
| int num = Integer.parseInt(arrOfCommands[1]); | ||
| return new DoneCommand(num); | ||
| } else if (command.startsWith("deadline")) { | ||
| return new AddCommand(command); | ||
| } else if (command.startsWith("todo")) { | ||
| return new AddCommand(command); | ||
| } else if (command.startsWith("event")) { | ||
| return new AddCommand(command); | ||
| } else if (command.startsWith("delete")) { | ||
| return new DeleteCommand(command); | ||
| } else if (command.startsWith("find")) { | ||
| return new FindCommand(command); | ||
| } |
Comment on lines
+27
to
+31
| String readCommand() { | ||
| Scanner scan = new Scanner(System.in); | ||
| String command = scan.nextLine(); | ||
| return command; | ||
| } |
There was a problem hiding this comment.
Consider creating a single scanner object in the main method instead of creating a new object every time the method is called.
This was referenced Feb 5, 2020
| fxmlLoader.setRoot(this); | ||
| fxmlLoader.load(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
In general, printing stack trace is not considered good exception handling. Think what better you can do here when an exception occurs?
| /** | ||
| * You should have your own function to generate a response to user input. | ||
| * Replace this stub with your completed method. | ||
| */ |
| ); | ||
| userInput.clear(); | ||
|
|
||
| if (response.startsWith("Bye-bye!")) { |
Refactored some code and deleted unused methods
Implemented assertions and removed unused methods
Implemented mass delete function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.