[Tuan Le] Duke Increments #143

youaremysky99 · 2020-01-28T23:41:44Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.

Level 1

level-1 delivery

level-2 delivery

level-3-delivery

level-4-delivery

level-5-delivery

level-6-delivery

Level-7

Level-8

khsc96

Overall nice use of OOP. Code is generally clean and readable except for some indentations problem.

khsc96 · 2020-02-04T10:08:39Z

src/main/java/CommandLineInterpreter.java

@@ -0,0 +1,80 @@
+package duke;
+import java.util.List;
+import duke.task.*;


Perhaps what you can do to prevent intellij from auto importing * is to change the settings in intellij by going to
File > settings > code style > java > imports > change the following:
Class count to use import *;
Names count to use static import with *;
to some large enough number

khsc96 · 2020-02-04T10:11:23Z

src/main/java/Commands/FindCommand.java

+import duke.Storage;
+import duke.TaskList;
+import duke.dukeException.DukeParseException;
+import java.util.ArrayList;
+import java.util.List;
+import duke.Interpreter;
+import duke.task.Task;
+import duke.DukeResponse;


Can consider grouping import with duke package together and separate it out with java.util package for better readability

khsc96 · 2020-02-04T10:15:09Z

src/main/java/Duke.java

+import java.util.Scanner;
+import java.util.List;
+import java.util.ArrayList;
+import duke.task.*;
+import java.io.IOException;
+import java.io.BufferedWriter;
+import java.io.FileWriter;
+import java.io.File;
+import duke.dukeException.DukeParseException;
+import duke.Interpreter;
+import duke.Storage;
+import duke.TaskList;	
+import duke.Parser;
+import duke.commands.Command;
+import javafx.application.Application;
+import javafx.scene.Scene;
+import javafx.scene.control.Label;
+import javafx.stage.Stage;
+import javafx.scene.control.Button;
+import javafx.scene.control.ScrollPane;
+import javafx.scene.control.TextField;
+import javafx.scene.layout.AnchorPane;
+import javafx.scene.layout.VBox;
+import javafx.stage.Stage;
+import javafx.scene.layout.Region;
+import javafx.scene.control.Label;
+import duke.DialogBox;
+import javafx.scene.image.Image;
+import javafx.scene.image.ImageView;	
+import javafx.application.Platform;
+import duke.DukeResponse;


Can consider regrouping this part too. Also the * import.

khsc96 · 2020-02-04T10:15:50Z

src/main/java/Duke.java

+	static final String separation = "_________________________________________________";
+	static final String greetingMessage = "Salue! Je suis Duke. \nWhat can I do for you?";
+	static final String pathToData = "data/storage.txt";
+	private Storage storage;
+	private TaskList taskList;
+	private Parser parser;
+	private ScrollPane scrollPane;


may want to change indentation to 4 spaces instead to suit coding standard

I think the final values should be named in capital letters.

khsc96 · 2020-02-04T10:17:54Z

src/main/java/Duke.java

+	 * the dialog container. Clears the user input after processing.
+	 */
+	private void handleUserInput() {
+		String userCommand = userInput.getText();


Here too have a weird indentation added, might want to remove it

khsc96 · 2020-02-04T10:33:42Z

src/main/java/Parser.java

+import duke.task.*;
+import duke.commands.*;
+
+public class Parser {


Perhaps can consider using your enum class here and use switch case instead

khsc96 · 2020-02-04T10:35:50Z

src/main/java/Storage.java

+					switch (type) {
+					case "todo":
+						containers.add(new ToDo(record));
+						break;
+					case "deadline":
+						containers.add(new Deadline(record));
+						break;
+					case "event":


Can perhaps use your enum class here too

It might be a good choice to increase readability for your codes.

khsc96 · 2020-02-04T10:39:11Z

src/main/java/Tasks/Deadline.java

+	public String toString() {
+		StringBuilder sb = new StringBuilder();
+		sb.append("  [D]")
+		  .append(super.getStatusIcon())
+		  .append(" ")
+		  .append(super.description)
+		  .append(" (by ")
+		  .append(this.date.format(DateTimeFormatter.ofLocalizedDate(FormatStyle.FULL)))
+		  .append(")");
+		return sb.toString();


Very nice use of indentations here, code is clean and very readable.
But I think you can check your tab key is it changed to 4 spaces instead of tab in intellij, your spaces looks like it is not 4 spaces.

khsc96 · 2020-02-04T10:41:32Z

src/main/java/Tasks/TaskType.java

@@ -0,0 +1,8 @@
+package duke.task;
+
+public enum TaskType {


Perhaps can consider removing this enum class, does not seems like it is being used.

Also, you can think about javaDoc as well here.

bluesky0911

Overall, well written. good job! however, you can think about javaDoc plus naming issues. For example, naming for final variables, some methods starting with capital latter, etc. :)

C-MassOps

A coding standard

A code quality

addAssertions

A user guide

changeuserguide

minor-update

j-lum and others added 30 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request #12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (#9)

Add configuration for console applications

a3ca5a4

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Merge pull request #13 from j-lum/javaexec

7b60e81

Add configuration for console applications

JavaFX tutorial: Support cross-platform JARs

c4678f7

The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.

JavaFX tutorial: Support cross-platform JARs [#16]

30efbae

Merge branch 'gradle' of https://github.com/youaremysky99/duke

6ded748

Merge pull request #1 from youaremysky99/level-1

5d9ed21

Level 1

level-1 delivery

76676af

Merge pull request #2 from youaremysky99/level-1

f4081b9

level-1 delivery

level-2 delivery

2b0d5a5

Merge pull request #3 from youaremysky99/level-2

0e091ce

level-2 delivery

level-3-delivery

bc48e98

Merge pull request #4 from youaremysky99/level-3

ef1de73

level-3-delivery

level-4-delivery

e234864

Merge pull request #5 from youaremysky99/level-4

276edb8

level-4-delivery

level-5-delivery

66df725

Merge pull request #6 from youaremysky99/level-5

b4ba266

level-5-delivery

level-6-delivery

5cca9d5

Merge pull request #7 from youaremysky99/level-6

4d7f3d5

level-6-delivery

Level-7

57029c5

Level-8

b2827b3

Merge pull request #10 from youaremysky99/level-7

0008c1f

Level-7

Merge pull request #11 from youaremysky99/level-8

85ae7dd

Level-8

A-Packages

f109da4

A-MoreOOP

435faaa

A-JUnit

48cb6fc

A-JavaDoc

1d4130e

khsc96 reviewed Feb 4, 2020

View reviewed changes

This was referenced Feb 4, 2020

Feedback on week 4 project progress for khsc96 khsc96/duke#3

Open

Feedback on week 4 project progress for joshlay96 joshlay96/duke#4

Open

youaremysky99 added 2 commits February 6, 2020 10:47

A-Assertions

8a5473b

C-MassOps

52c4ece

bluesky0911 reviewed Feb 11, 2020

View reviewed changes

youaremysky99 and others added 24 commits February 12, 2020 00:14

more-fixes

7284d7b

morefixes

b48f8a4

morefixes

b9b85e6

morefixes

a98a61f

st

cbf9091

Merge pull request #21 from youaremysky99/C-MassOps

854be24

C-MassOps

Merge branch 'master' into A-CodingStandard

d4c1790

Merge pull request #19 from youaremysky99/A-CodingStandard

a7c0b2c

A coding standard

add-resize

e3d9c49

adding-jvdocs

c4faf1a

adding-jvdocs

d36bb11

Merge pull request #23 from youaremysky99/A-CodeQuality

81a28c4

A code quality

addAssertions

2d1f49e

Merge pull request #24 from youaremysky99/A-Assertions

85a8c1e

addAssertions

Set theme jekyll-theme-slate

8e109e0

adduserguid

27254b8

adduserguid

f45feef

Merge pull request #25 from youaremysky99/A-UserGuide

af2da07

A user guide

changeuserguide

1ef991e

Merge pull request #26 from youaremysky99/A-UserGuide

bfcde9f

changeuserguide

minor-update

b64d184

Merge pull request #27 from youaremysky99/A-UserGuide

f80836e

minor-update

minor-update

412e6b0

Merge pull request #28 from youaremysky99/A-UserGuide

bce7bb9

minor-update

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tuan Le] Duke Increments #143

[Tuan Le] Duke Increments #143

youaremysky99 commented Jan 28, 2020

khsc96 left a comment

khsc96 Feb 4, 2020 •

edited

Loading

khsc96 Feb 4, 2020

khsc96 Feb 4, 2020

khsc96 Feb 4, 2020

bluesky0911 Feb 11, 2020

khsc96 Feb 4, 2020

khsc96 Feb 4, 2020

khsc96 Feb 4, 2020

bluesky0911 Feb 11, 2020

khsc96 Feb 4, 2020 •

edited

Loading

bluesky0911 Feb 11, 2020

khsc96 Feb 4, 2020

bluesky0911 Feb 11, 2020

bluesky0911 left a comment

[Tuan Le] Duke Increments #143

Are you sure you want to change the base?

[Tuan Le] Duke Increments #143

Conversation

youaremysky99 commented Jan 28, 2020

khsc96 left a comment

Choose a reason for hiding this comment

khsc96 Feb 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khsc96 Feb 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bluesky0911 left a comment

Choose a reason for hiding this comment

khsc96 Feb 4, 2020 •

edited

Loading

khsc96 Feb 4, 2020 •

edited

Loading