[Wong Jun Long] iP #100
[Wong Jun Long] iP #100
Conversation
Delete and gitignore class files
Delete and gitignore class files
# Conflicts: # text-ui-test/runtest.bat Resolved by combining both FileManipulator and DateTime java compilation paths into runtest.bat
Conflicts: src/main/java/exception/DukeException.java src/main/java/parser/Parser.java src/main/java/storage/Storage.java src/main/java/task/TaskList.java src/main/java/task/tasks/Task.java Conflicts occurred because of minor white spaces issues. Amended code and integrated changes from both branches.
|
Commonly used variables could be saved as a constant such as dividers in the TaskDescription class. Method names should be verbs describing an action and not be in the past tense such as the addedTaskDescription method. More whitespace could be added for bigger chunks of code to improve readability. Besides these, coding standards are abided by, with sufficient comments that aid in understanding the code base. Good job! |
There was a problem hiding this comment.
The Javadoc comments are really detailed and clear. They makes the code base really easy to understand. There are several method names which could possibly be improved in terms of naming style and the spacing between the parameters name and descriptions can be more consistent. Overall, the coding standards are strictly abided by and there are very few violations. I really like the work done! :) 👍
| /** | ||
| * Renders an error message that user input has been written incorrectly. | ||
| */ | ||
| public static String invalidCommand() { |
There was a problem hiding this comment.
Perhaps use verbs for this and the following methods' names?
Duke A-CodeQuality: Improve Code Quality
# Conflicts: # src/main/java/task/TaskDescription.java # src/main/java/task/TaskList.java Resolved conflicts by integrating assertions and code quality changes
Duke A-Assertions: Use Assertions
Duke C-NaturalDates: Use Natural Dates
|
Your code is very readable and easy to understand with comprehensive java docs and additional detailed comments! |
No description provided.