[Lin Yuan Xun, Caleb] iP #102

Caleblyx · 2020-08-22T04:20:45Z

No description provided.

# Conflicts: # src/main/java/Bob.java Resolution: keep all changes

Add J-Unit tests for the following classes: Parser, TaskList, and Event.

Improve coding standard

# Conflicts: # src/main/java/AddCommand.java # src/main/java/Bob.java # src/main/java/BobIncompleteEventDescriptionException.java # src/main/java/Deadline.java # src/main/java/DeleteCommand.java # src/main/java/Event.java # src/main/java/ExitCommand.java # src/main/java/Storage.java # src/main/java/Task.java # src/main/java/TaskList.java # src/main/java/Todo.java # src/main/java/UI.java Resolution: Keep javadocs and coding standard improvements

# Conflicts: # data/save.txt # src/main/java/TaskList.java Resolution: keep all changes made in the two branches.

aqcd

The main functionality looks good!
Some parts of the code, such as the Parser class, could do with more documentation as I was rather confused as to what the code is doing.
A few cosmetic changes requested.

aqcd · 2020-08-31T05:35:29Z

data/save.txt

@@ -0,0 +1,10 @@
+<<<<<<< HEAD


This might have been missed while merging! Should this be here?

aqcd · 2020-08-31T05:39:33Z

src/main/java/Bob.java

@@ -0,0 +1,41 @@
+import main.java.*;


Would it be clearer to list the imported classes explicitly?

aqcd · 2020-08-31T05:40:36Z

src/main/java/Bob.java

+public class Bob {
+    private TaskList tasks = new TaskList();
+    private Storage storage;
+    private UI uI;


Should this variable be named "ui" instead?

aqcd · 2020-08-31T05:41:44Z

src/main/java/BobDateTimeParseException.java

+/**
+ * An exception that may be thrown when an error occurs during the parsing of dates and times.
+ */
+public class BobDateTimeParseException extends BobException {


I like that you made classes for the specific types of exceptions!

aqcd · 2020-08-31T05:45:32Z

src/main/java/Event.java

+     */
+    public Event (String description, String period) {
+        super(description);
+        this.start = LocalDateTime.parse(period.substring(0,15), inputFormatter);


Should the call to .substring be formatted in a better way? Noticed this in a few other places as well!

aqcd · 2020-08-31T05:49:02Z

src/main/java/ExitCommand.java

+    /**
+     * Returns false to indicate that Bob may terminate.
+     *
+     * @return false.


Should this method be returning false? It's currently returning true.

aqcd · 2020-08-31T05:53:34Z

src/main/java/Storage.java

+        }
+    }
+
+    /**Updates the Storage's text file according to the tasks in a provided TaskList.


Should this JavaDoc be in the next line?

aqcd · 2020-08-31T05:54:02Z

src/main/java/Storage.java

+
+    /**
+     * Closes the Storage's writer.
+     * @throws BobIOException if the Storage's text file does not exist.


Should this line be 1 extra line below the previous? Noticed this in some other places too!

aqcd · 2020-08-31T05:55:57Z

src/main/java/Todo.java

+     * @param isDone indicates if the todo is completed.
+     * @param description brief description of the todo.
+     */
+


Noticed some extra lines after JavaDocs. Should the JavaDoc style be consistent?

aqcd · 2020-08-31T05:56:23Z

src/main/java/UI.java

+     * @throws BobIndexOutOfBoundsException if the method tries to retrieve a task with an index not on the list.
+     */
+    public void printOutList(TaskList tasks) throws BobIndexOutOfBoundsException {
+        for(int i = 1; i < tasks.size()+1; i++) {


Should this line be better spaced?

kerkpy

The coding style looks good!

kerkpy · 2020-09-01T17:22:06Z

src/main/java/AddCommand.java

+     * @return true or false if AddCommand is equal or not equal to the object respectively.
+     */
+    @Override
+    public boolean equals(Object o) {


Could the variables for be more descriptive? That is, instead of o, be obj, and instead of c, be cmd

kerkpy · 2020-09-01T17:29:38Z

src/main/java/Task.java

+ */
+public class Task {
+    /** A brief description of the task. */
+    protected String description;


Should they have been private instead of protected?

kerkpy · 2020-09-01T17:31:10Z

src/main/java/TaskList.java

+public class TaskList {
+
+    /** An array list consisting of tasks. */
+    private ArrayList<Task> list;


should this have been renamed as tasks?

kerkpy · 2020-09-01T17:32:29Z

src/main/java/UI.java

+    public void printOutList(TaskList tasks) throws BobIndexOutOfBoundsException {
+        for(int i = 1; i < tasks.size()+1; i++) {
+            Task task = tasks.get(i);
+            System.out.println(i +"." + task.toString());


Should there be spacing between +"." ?

kerkpy · 2020-09-01T17:33:02Z

src/main/java/UI.java

+            Task task = tasks.get(i);
+            System.out.println(i +"." + task.toString());
+        }
+        if(tasks.isEmpty()) {


Should there be spacing between if(..)?

add a GUI

add assertions to code

# Conflicts: # src/main/java/bob/command/DeleteCommand.java Resolution: Retain changes made by both branches

…ine creation

Change Bob profile picture Improve label design and font Improve error message GUI

-Change exception messages -Edit exception handling of Parse.parseDelete and Parse.parseDone

-Add option to delete all tasks -Add option to mark all tasks as done

-Add javadocs for new methods. -Edit old javadocs

damithc and others added 9 commits July 23, 2020 23:27

Add Gradle support

3b19ba1

Level1 - Greet, Echo, Exit

1e972e8

Level 2. Add, List

25160e1

Level-3: Mark as Done

d13baf0

Level-4: ToDo, Event, Deadline

4eba2dd

A-TextUiTesting: Automated Text UI Testing

946d62c

Level-5: Handle Errors

38733ff

Level-6: Delete

22562f4

Done exception

077e10e

Caleblyx changed the title ~~Lin Yuan Xun, Caleb iP~~ [Lin Yuan Xun, Caleb] iP Aug 22, 2020

Caleblyx added 13 commits August 23, 2020 00:51

Level 7. Save

c7b3136

Level 8. Dates and Times

b2cbcc1

Merge branch 'branch-level-7'

456cf0c

Merge branch 'branch-level-8'

517f474

# Conflicts: # src/main/java/Bob.java Resolution: keep all changes

A-MoreOOP

78b89db

A-JUnit

4b337a5

Add J-Unit tests for the following classes: Parser, TaskList, and Event.

A-JavaDoc

c10f2b7

Add JavaDoc for class variables of Storage class

792c51a

branch-A-CodingStandard

c3274a7

Improve coding standard

branch-level-9

3a8dde9

Merge tag 'branch-A-JavaDoc'

6f0f775

Merge branch 'branch-level-9'

b680d18

# Conflicts: # data/save.txt # src/main/java/TaskList.java Resolution: keep all changes made in the two branches.

aqcd reviewed Aug 31, 2020

View reviewed changes

Caleblyx added 3 commits August 31, 2020 19:54

add /src/test/.idea to .gitignore

b3aea23

Merge branch 'add-gradle-support'

7ce737d

Set up Gradle to build, run, and test using Gradle

85d0d70

kerkpy reviewed Sep 1, 2020

View reviewed changes

Caleblyx added 2 commits September 2, 2020 13:58

branch-level-10

780efea

add a GUI

Merge tag 'branch-level-10'

d2f87e8

Caleblyx and others added 30 commits September 2, 2020 14:22

branch-A-CheckStyle

8c8f639

Merge branch 'branch-A-CheckStyle'

39f8ae4

Improve code quality

c2a89fd

add assertions to code

cdfde82

Make further improvements to code quality of Parser.java

6c61127

Merge pull request #1 from Caleblyx/heads/branch-A-Assertions

a0b422b

add assertions to code

Merge tag 'branch-A-CodeQuality'

225185f

# Conflicts: # src/main/java/bob/command/DeleteCommand.java Resolution: Retain changes made by both branches

Add snooze and reschedule commands

d81cb80

fix minor syntax errors

8abe404

add exception handling for snoozing, rescheduling, and event or deadl…

a6a4c5b

…ine creation

Merge branch 'branch-BCD-extension-snooze'

348486a

improve GUI

ad58bf1

make profile picture circular

02f2f1b

make dialogbox resize dynamically according to content

adb50cb

change format of error messages on GUI

31ea772

Improve GUI

5ca77e3

Change Bob profile picture Improve label design and font Improve error message GUI

Modify exception handling

0470159

-Change exception messages -Edit exception handling of Parse.parseDelete and Parse.parseDone

Improve delete and done commands

c29f7d1

-Add option to delete all tasks -Add option to mark all tasks as done

Rename exception class

30739dc

Modify javadocs

f77c85d

-Add javadocs for new methods. -Edit old javadocs

Set theme jekyll-theme-cayman

0673032

Add credits for adapted code

7f61184

Delete _config.yml

844953a

Merge branch 'master' of https://github.com/Caleblyx/ip

cc16f72

Edit introduction README.MD

60b803e

Add user guide and edit portfolio page

81e360d

Modify portfolio page

2fbefec

Change User Guide URL on portfolio page

0c1b971

Modify portfolio page

f0d4905

Modify build.gradle file

0ec23d6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lin Yuan Xun, Caleb] iP #102

[Lin Yuan Xun, Caleb] iP #102

Caleblyx commented Aug 22, 2020

aqcd left a comment

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

aqcd Aug 31, 2020

kerkpy left a comment

kerkpy Sep 1, 2020

kerkpy Sep 1, 2020

kerkpy Sep 1, 2020

kerkpy Sep 1, 2020

kerkpy Sep 1, 2020

[Lin Yuan Xun, Caleb] iP #102

Are you sure you want to change the base?

[Lin Yuan Xun, Caleb] iP #102

Conversation

Caleblyx commented Aug 22, 2020

aqcd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerkpy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment