[Gao Gui] iP #115
Open
[Gao Gui] iP #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricktan6
reviewed
Sep 2, 2020
src/main/java/Deadline.java
Outdated
Comment on lines
13
to
15
| return "[D]" + super.toString() + " (by: " + by.getMonth().toString().substring(0, 3) + " " + | ||
| by.getDayOfMonth() + " " + by.getYear() + " " + | ||
| String.format("%d:%d)", by.getHour(), by.getMinute()) + ")"; |
There was a problem hiding this comment.
I think placing the '+' in front of every line is better.
patricktan6
reviewed
Sep 2, 2020
src/main/java/Duke/Deadline.java
Outdated
| protected LocalDateTime by; | ||
|
|
||
| /** | ||
| * Constructs an event with a deadline. |
There was a problem hiding this comment.
It would be better to leave a line after the description.
patricktan6
approved these changes
Sep 2, 2020
branch-A-Assertions
branch-A-CodeQuality
branch-A-Lambdas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.