[Wang Ri Zhao] iP #116
Open
[Wang Ri Zhao] iP #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type of tasks include - event - deadline - todo
Type of tasks include - event - deadline - todo
…ing for deadline and event methods
…ing for deadline and event methods
A-check style use check style #22
Branch a level10
li-s
reviewed
Sep 3, 2020
src/main/java/duke/Duke.java
Outdated
| if (cmd.isExit()) { | ||
| break; | ||
| } | ||
| } catch (DukeException e) { |
There was a problem hiding this comment.
Could the exception e be mroe descriptive?
There was a problem hiding this comment.
I'm not too sure what do you mean here 😅
There was a problem hiding this comment.
Sorry, I don't get what you mean here. 😅
| throw Ui.taskDateEmptyException(super.getCommandType()); | ||
| } | ||
|
|
||
| String name = taskParts[0]; |
There was a problem hiding this comment.
What does name refer to here? the command (todo, deadline), or the description of the task?
There was a problem hiding this comment.
It refers to the name (aka description) of the deadline task. I think the naming could be more descriptive, e.g. deadlineName. But I am using just name for the name, so that it is consistent with the rest of the commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.