Chia Chu You iP #130

chuyouchia · 2020-08-22T07:44:39Z

No description provided.

…y them back to the user when requested.

…vents

…ng of Duke.

…e user.

…ith errors such as incorrect inputs entered by the user.

…rrentStatus method call. Level-5: Teach Duke to deal with errors such as incorrect inputs entered by the user.

Original code contained UI and logic in the main method. As a result, if there are any changes to be made to a specific scenario, problems are not isolated into individual methods or cases. Simplified the driver method to be solely responsible for console input and dependent on other static methods. By separating the responsibility into smaller chunks, it will improve debugging process if necessary. Java Doc comments have been added to describe individual methods as well.

Original code was treating all date time formats simply as strings. Add the function for the tasks to have stored date time. Command "list-due" added for filtering options on deadline and commitments.

…ndler. Save the task list to hard disk so that past tasks recorded would not be lost when the program terminates.

# Conflicts: # src/main/java/com/jacob/Duke/Deadline.java # src/main/java/com/jacob/Duke/Duke.java # src/main/java/com/jacob/Duke/Event.java # src/main/java/com/jacob/Duke/Task.java

…ace into Packages Original code had repeated UI elements and combined Commands with Parser, which resulted in unnecessary repeated code between commands. Extracted the following classes: - Ui: deals with interactions with the user - Renamed FileEditor to Storage: deals with loading tasks from the file and saving tasks in the file - Parser: deals with making sense of the user command - TaskList: contains the task list e.g., it has operations to add/delete tasks in the list - Command: that implements a Command Interface with Execute and isBye methods. Extracting the class allows for method reusing and modularity as codebase grows.

@test

JUnit enables automated testing for Test Driven Development. Note: - implementation 'org.junit.jupiter:junit-jupiter-api:5.5.1' is required to make sure that the import for @test annotation does not fail - Set the System.out to a byteArrayOutput Stream so that it is possible to capture console output for testing purposes.

# Conflicts: # src/main/java/com/jacob/duke/DukeException.java # src/main/java/com/jacob/duke/TaskList.java # src/main/java/com/jacob/duke/command/ByeCommand.java # src/main/java/com/jacob/duke/command/DeadlineCommand.java # src/main/java/com/jacob/duke/command/DeleteCommand.java # src/main/java/com/jacob/duke/command/DoneCommand.java # src/main/java/com/jacob/duke/command/EventCommand.java # src/main/java/com/jacob/duke/command/PrintFilteredListCommand.java # src/main/java/com/jacob/duke/command/PrintListCommand.java # src/main/java/com/jacob/duke/task/Todo.java

Give users a way to find a task by searching for a keyword. # Conflicts: # src/main/java/com/jacob/duke/Ui.java # src/main/java/com/jacob/duke/command/PrintFilteredListDateTimeCommand.java

yuxuanxc

I think the main issue is with the javadoc comments, maybe you will need to spend some time fixing your current comments to adhere to the coding standard guidelines. Remember to put a full stop behind every summary, param, return etc and leave an empty line after the summary before you start writing the parameters in the future! Sorry for spamming a lot of comments regarding extra spaces, I just thought that removing them would make your code look more consistent and organized. Other than that, the naming and layout all seems fine. Good job! :D

yuxuanxc · 2020-09-01T12:41:17Z

src/main/java/com/jacob/duke/Duke.java

+
+    /**
+     * Constructor for Duke
+     * @param filePath contains file where task list is saved


There should be a punctuation (full-stop) behind each parameter description.
Remember to put an empty line between description and parameter section.

I see, thank you for pointing that out!

yuxuanxc · 2020-09-01T12:44:06Z

src/main/java/com/jacob/duke/Duke.java

+    private Ui ui;
+
+    /**
+     * Constructor for Duke


I think we need to include a full-stop at the back of the summary to indicate the end of the sentence, so that Javadoc will automatically place it in the method summary table(of your API)?

yuxuanxc · 2020-09-01T12:57:39Z

src/main/java/com/jacob/duke/Parser.java

@@ -0,0 +1,58 @@
+package main.java.com.jacob.duke;
+
+import main.java.com.jacob.duke.command.*;


I think we still need to import every single class specifically instead of using a wildcard(*), even if all of the classes in that package is being used. I went to google about this a little but there are conflicting answers as to whether wildcards should be used or not, so maybe you can clarify it with your TA/the profs?

I actually did try that, but it seems like my IntelliJ automatically refactors the code to the * type import. Are you facing the same problems?

I found this online! (source: https://www.jetbrains.com/help/idea/creating-and-optimizing-imports.html#exclude-from-auto-import)
Disable wildcard imports to always import single classes:

In the Settings/Preferences dialog Ctrl+Alt+S, select Code Style | Java | Imports.

Make sure that the Use single class import option is enabled.

In the Class count to use import with ‘’ and Names count to use static import with ‘’ fields, specify values that definitely exceed the number of classes in a package and the number of names in a class (for example, 999).

Thank you, that works 👍

yuxuanxc · 2020-09-01T13:00:18Z

src/main/java/com/jacob/duke/Storage.java

+import main.java.com.jacob.duke.task.Task;
+import main.java.com.jacob.duke.task.Todo;
+
+


There's a few extra spaces here.

I see, thank you for pointing that out!

yuxuanxc · 2020-09-01T13:03:47Z

src/main/java/com/jacob/duke/Storage.java

+        java.nio.file.Path directoryPath = java.nio.file.Paths.get(current, parent);
+        boolean directoryExists = java.nio.file.Files.exists(directoryPath);
+
+


There's one extra space here, not sure if it is a violation but you might want to delete it so that your code will look more consistent throughout? There is one extra space at line 65 too

yuxuanxc · 2020-09-01T13:16:26Z

src/main/java/com/jacob/duke/command/ByeCommand.java

@@ -0,0 +1,31 @@
+package main.java.com.jacob.duke.command;
+import java.util.List;


Need to add a space above!

yuxuanxc · 2020-09-01T13:17:33Z

src/main/java/com/jacob/duke/command/DeadlineCommand.java

@@ -0,0 +1,58 @@
+package main.java.com.jacob.duke.command;
+import java.util.List;


Need space above this line.

yuxuanxc · 2020-09-01T13:18:07Z

src/main/java/com/jacob/duke/command/DeadlineCommand.java

+    public DeadlineCommand(String fullCommand) {
+        this.inputCommand = fullCommand;
+    }
+    /**


Need space above this line?

yuxuanxc · 2020-09-01T13:20:45Z

src/main/java/com/jacob/duke/command/DoneCommand.java

+import main.java.com.jacob.duke.TaskList;
+import main.java.com.jacob.duke.Ui;
+
+import main.java.com.jacob.duke.task.Task;


Extra spaces in lines 8, 11 and 12

yuxuanxc · 2020-09-01T13:21:53Z

src/main/java/com/jacob/duke/command/PrintFilteredListDateTimeCommand.java

+import main.java.com.jacob.duke.Ui;
+import main.java.com.jacob.duke.task.Task;
+
+


Why got so many spaces haha. This is not a violation so I don't want to keep spamming the same comment.

Just in case if you want to fix the extra spaces for the sake of aesthetics, here are some which I found in other files which I didn't comment:
TodoCommand.java - line 12
Event.java - line 3
UiTest.java - line 14

Thank you for pointing that out! Will refactor accordingly in my next release 👍

Refactor UI and UI testing to support string validation

Add changes to adhere to JavaDocs Coding standards

Add assertions to source code to document assumptions

hopinxian

Overall, I like the assertions used to support your program. I think that is something I ought to learn. There are still some room for improvements. If you are using Intellij, I would suggest using the "Reformat code" function under the code tab. This would help you with the random white spaces that appear.

hopinxian · 2020-09-07T15:36:40Z

data/duke.txt

+D,1,return book,2019-11-13 1800
+T,0,funny
+T,0,nani what is happening to me
+E,0,omomomo,2019-11-15 1900


May I suggest adding more line inputs with respect to the increasing levels? I find that maintaining this text assists greatly with testing.

Yup this make sense. I actually have separate test files and duke.txt is really just a dummy text file that I ignored after the start.

hopinxian · 2020-09-07T15:38:30Z

src/main/java/com/jacob/duke/Parser.java

@@ -0,0 +1,63 @@
+package main.java.com.jacob.duke;


May I suggest putting the Parser and Storage class within a IO package?

Makes sense, thanks for the suggestion!

hopinxian · 2020-09-07T15:40:45Z

src/main/java/com/jacob/duke/Storage.java

+     * Replaces a specific line of text in the string buffer read
+     * @param lineToEdit text to be replaced


I believe within the coding standard, it is stated there should be a line break between the description and parameter block. Perhaps you check to confirm? This goes for other places within this project as well.

Yup thanks, have rectified in my latest release.

hopinxian · 2020-09-07T15:43:38Z

src/main/java/com/jacob/duke/command/DeadlineCommand.java

+        List<Task> taskList = tasks.getTaskList();
+        int breakpoint = inputCommand.indexOf("/") - 1;
+        if (inputCommand.length() <= "deadline ".length()) {
+            throw new DukeException("☹ OOPS!!! The description of a Deadline cannot be empty.");
+        } else if (breakpoint == -2) {
+            throw new DukeException("Hey a deadline cannot have no actual date!!");
+        }
+        String description = inputCommand.substring("deadline".length() + 1, breakpoint);
+        String dateTime = inputCommand.substring(breakpoint + 5);
+        Task theDeadline = new Deadline(description, dateTime);
+        taskList.add(theDeadline);


This block feels quite lengthy. Perhaps it would be better to add some line breaks for readability.

hopinxian · 2020-09-07T15:46:39Z

src/main/java/com/jacob/duke/Parser.java

+import main.java.com.jacob.duke.command.PrintListCommand;
+import main.java.com.jacob.duke.command.TodoCommand;
+
+public class Parser {


I believe there is quite some functions within other classes that would be better encapsulated within this class. Examples are detecting for invalid indexes, incomplete commands and so forth. I would suggest that Parser also have additional capabilities to identify invalid commands. I believe this would fall under the role of parsing the user input.

Yup agreed, thanks for the insight! I will probably refactor instead of using line breaks to improve readability

Place parser and storage into io package for better readability and categorization

Branch extra-exceptionhandling

It is now called the fireside chat with the Mamba.

chuyouchia added 22 commits August 16, 2020 11:23

Duke Level 1: Greet, Echo & Exit

304eebd

Add the ability to store whatever text entered by the user and displa…

848a80e

…y them back to the user when requested.

Add the ability to mark tasks as done.

4ddade4

Add support for tracking three types of tasks: Todos, Deadlines and E…

e515693

…vents

Use the input/output redirection technique to semi-automate the testi…

1f898b1

…ng of Duke.

Teach Duke to deal with errors such as incorrect inputs entered by th…

8054ef9

…e user.

Fixed bug in list command for level 5. Level 5 - Teach Duke to deal w…

1f1646a

…ith errors such as incorrect inputs entered by the user.

Fixed Minor bug in level 5 due to missing white space in Task's getCu…

cf85ea8

…rrentStatus method call. Level-5: Teach Duke to deal with errors such as incorrect inputs entered by the user.

Level-6: Add support for deleting tasks from the list.

13fba26

Add ability to parse date time format in command:

36d83d7

Original code was treating all date time formats simply as strings. Add the function for the tasks to have stored date time. Command "list-due" added for filtering options on deadline and commitments.

Add ability to access file system & refactor commands into Command Ha…

e99e4dd

…ndler. Save the task list to hard disk so that past tasks recorded would not be lost when the program terminates.

Merge branch 'branch-Level-8' with master

9d9accb

# Conflicts: # src/main/java/com/jacob/Duke/Deadline.java # src/main/java/com/jacob/Duke/Duke.java # src/main/java/com/jacob/Duke/Event.java # src/main/java/com/jacob/Duke/Task.java

Fix file creation bug discovered during JAR file level

751a0f7

Add JavaDoc comments for all public methods in production code

7b29511

Tweak all code to comply with given coding standard

21e221c

Fix bug resulting in unhandled exception due to non-existent breakpoint

82b934a

Add a find command to search tasks for specified string

0e3ea6f

Merge branch 'branch-Level-9'

7d8401d

Give users a way to find a task by searching for a keyword. # Conflicts: # src/main/java/com/jacob/duke/Ui.java # src/main/java/com/jacob/duke/command/PrintFilteredListDateTimeCommand.java

yuxuanxc reviewed Sep 1, 2020

View reviewed changes

Add GUI using Java Fx Technology

91bd742

Refactor UI and UI testing to support string validation

chuyouchia force-pushed the master branch from e25cbe9 to 7d8401d Compare September 1, 2020 15:39

chuyouchia added 5 commits September 3, 2020 20:55

Add welcome message for duke

0a64db6

Add assertions to source code to document assumptions

c617190

Improve Code Quality by extracting and naming variables.

d016f61

Add changes to adhere to JavaDocs Coding standards

Merge pull request #1 from chuyouchia/branch-A-Assertions

e6027a2

Add assertions to source code to document assumptions

Merge branch 'master' into branch-A-CodeQuality

e2dd78d

Update to remove checkstyle errors detected by CI

281e389

hopinxian reviewed Sep 7, 2020

View reviewed changes

chuyouchia added 28 commits September 8, 2020 08:03

Add D-Notes as extension

f4d0f42

Add D-Notes as extension

63ce677

Update checkstyle imports errors

8151d3a

Refactor parser to deal with obvious incomplete commands

461ee88

Place parser and storage into io package for better readability and categorization

Update imports

5d63304

Fix import statements

d74a605

Merge pull request #3 from chuyouchia/branch-D-Notes

a4aa994

Add unit tests and exception handling for invalid commands.

7f4f47f

Fix checkstyle errors

15fd188

Move JavaFx related code into javafx package

f904221

Merge pull request #4 from chuyouchia/branch-extraexceptionhandling

a8ee342

Branch extra-exceptionhandling

Add Dark Theme and CSS stylings to Duke.

0e5cd42

It is now called the fireside chat with the Mamba.

Add scroll pane resizing and dialog box resizing

4549bf4

Merge branch 'branch-A-BetterGUI'

0ffbf4a

Fix misspell in UI test due to added personality for chatbot

f1580b5

Add description for note related commands when starting up app

3dfbd5c

Add content for user guide into readme.md

2391679

Update Mamba interface linebreak in readme.md

0988b3b

Set theme jekyll-theme-hacker

9917786

Update README.md

81a6250

Update README.md

9ac4754

Change help message format for date time format error in commands.

520d9bd

Fix delete command invalid index errors.

466f9da

Update README.md

be16886

Update README.md

e60dbd5

Add function for bye input to close window automatically.

5d262b1

Fix checkstyle error

32582b3

Add credits to source where css file was adapted from.

1454a0e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chia Chu You iP #130

Chia Chu You iP #130

chuyouchia commented Aug 22, 2020

yuxuanxc left a comment

yuxuanxc Sep 1, 2020

chuyouchia Sep 2, 2020

yuxuanxc Sep 1, 2020

yuxuanxc Sep 1, 2020

chuyouchia Sep 2, 2020

yuxuanxc Sep 2, 2020

chuyouchia Sep 3, 2020

yuxuanxc Sep 1, 2020

chuyouchia Sep 2, 2020

yuxuanxc Sep 1, 2020

yuxuanxc Sep 1, 2020

yuxuanxc Sep 1, 2020

yuxuanxc Sep 1, 2020

yuxuanxc Sep 1, 2020

yuxuanxc Sep 1, 2020

chuyouchia Sep 2, 2020

hopinxian left a comment

hopinxian Sep 7, 2020

chuyouchia Sep 8, 2020

hopinxian Sep 7, 2020

chuyouchia Sep 8, 2020

hopinxian Sep 7, 2020

chuyouchia Sep 8, 2020

hopinxian Sep 7, 2020

hopinxian Sep 7, 2020

chuyouchia Sep 8, 2020

		@@ -0,0 +1,58 @@
		package main.java.com.jacob.duke;

		import main.java.com.jacob.duke.command.*;

		import main.java.com.jacob.duke.task.Task;
		import main.java.com.jacob.duke.task.Todo;

		java.nio.file.Path directoryPath = java.nio.file.Paths.get(current, parent);
		boolean directoryExists = java.nio.file.Files.exists(directoryPath);

		@@ -0,0 +1,31 @@
		package main.java.com.jacob.duke.command;
		import java.util.List;

		import main.java.com.jacob.duke.Ui;
		import main.java.com.jacob.duke.task.Task;

		* Replaces a specific line of text in the string buffer read
		* @param lineToEdit text to be replaced

Chia Chu You iP #130

Are you sure you want to change the base?

Chia Chu You iP #130

Conversation

chuyouchia commented Aug 22, 2020

yuxuanxc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hopinxian left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment