[Cheak Han Wei] iP #154

hanweic53 · 2020-08-22T11:55:33Z

No description provided.

Updated A-TextUiTesting to test for errors

Updated A-TextUiTesting to test for Delete

Tasks are not saved and only stored in temporary variables. Users start the program with clean data. We will save the data in the hard disk and load the data when Duke starts up.

Dates were stored as Strings. Not very meaningful to do so. Parsing dates and storing them as LocalTimeDate Objects allow us to perform more meaningful operations that deal with time and also to standardise users' input.

Code was merged from branch-Level-8 to master branch. Errors were thrown when Duke was ran. Refactored Level-8.

Made the program more OOP by extracting Ui, Parser, TaskList and the Commands classes.

Working directory is very cluttered. Put the files into different packages.

Add JUnit for testing code. Added methods to test methods in AddCommand, DeleteCommand and ExitCommand classes.

Added JavaDocs to Commands classes and Duke. JavaDocs helps external users to understand our code better.

Tweak the code to comply with the SE-EDU coding standard.

Give users a way to find a task by searching for a keyword.

Missed out the FindCommand class in the previous commit.

Automate project builds using Gradle. Gradle can run Unit tests, as well as run the Duke program.

To detect coding style violations.

Simple GUI implemented for Duke.

Implemented GUI using fxml.

Zhang-Yunjie

LGTM, almost. I like how you structure your classes very neatly so that it is easy to understand as someone new to your codes :) Good job 👍

Zhang-Yunjie · 2020-09-02T07:57:21Z

src/main/java/duke/task/TaskList.java

+
+    private void printTotalNumberOfTasks() {
+        int numTasks = tasks.size();
+        if (numTasks < 2) {


Is there a better way to structure these to extract common code and reduce duplicates?

Zhang-Yunjie · 2020-09-02T08:50:56Z

src/main/java/Duke.java

+     */
+    public void run() {
+        ui.showWelcome();
+        boolean isExit = false;


Would it be better to change "isExit" to "hasExit" to make it more natural?

Zhang-Yunjie · 2020-09-02T09:16:47Z

src/main/java/duke/command/Command.java

+     *
+     * @return true or false
+     */
+    public abstract boolean isExit();


May I ask why this must be a method instead of a boolean attribute?

Zhang-Yunjie · 2020-09-02T09:29:03Z

src/main/java/duke/command/ListCommand.java

+     * @param storage storage storage that handles data storage
+     */
+    @Override
+    public void execute(TaskList tasks, Ui ui, Storage storage) {


Would it be better to name it more specifically, e.g. "listOutTasks" instead of "execute" ?

To satisfy the iP Progress Dashboard. Something went wrong with the previous A-Gradle tagging.

xuey0ng

I like the way you structure your classes! . Overall LGTM:)

xuey0ng · 2020-09-02T15:38:51Z

src/main/java/MainWindow.java

+     * the dialog container. Clears the user input after processing.
+     */
+    @FXML
+    private void handleUserInput() {


Perhaps you might want add a condition to check if the user wants to exit, before using Platform.exit() to terminate the javaFx window.

xuey0ng · 2020-09-02T15:39:17Z

src/main/java/duke/command/AddCommand.java

+            switch (commandWord) {
+            case "todo":
+                return taskList.addTodo(taskName, storage);
+
+            case "deadline":
+                return taskList.addDeadline(taskName, storage);
+
+            case "event":
+                return taskList.addEvent(taskName, storage);
+
+            default:
+                return "";


Nice job on the switch indentation!

Wrote assumptions that should hold at various points in the code.

Examine code and refactor to improve code quality.

Add A-Assertions: Use Assertions

Add A-CodeQuality

Use Continuous Integration.

Futher improvements on code quality.

Allows tagging of tasks.

HynRidge

Hey Buddy! Your code looks clean and all things seem to be well abstracted.. Kudos

damithc and others added 30 commits July 23, 2020 23:27

Add Gradle support

3b19ba1

Completed Level-1: Greet, Echo, Exit

ab298da

Completed Level-2: Add, List

8089e76

Completed Level-3: Mark as Done

3369632

Completed Level-4: ToDos, Events, Deadlines

ac9730d

Completed A-TextUiTesting

40e6cc1

Completed Level-5: Handle Errors

d9d6034

Updated A-TextUiTesting to test for errors

Completed Level-6: Delete

b6ac1c1

Updated A-TextUiTesting to test for Delete

Add Level-7: Save

b71442e

Tasks are not saved and only stored in temporary variables. Users start the program with clean data. We will save the data in the hard disk and load the data when Duke starts up.

Add Level-8: Dates and Times

ee3b376

Dates were stored as Strings. Not very meaningful to do so. Parsing dates and storing them as LocalTimeDate Objects allow us to perform more meaningful operations that deal with time and also to standardise users' input.

Merge branch 'branch-Level-7' into master

b845249

Merge branch 'branch-Level-8' into master

92faf33

Refactor Level-8: Dates and Times

77a03ea

Code was merged from branch-Level-8 to master branch. Errors were thrown when Duke was ran. Refactored Level-8.

Add A-MoreOOP: Use More OOP

7daf963

Made the program more OOP by extracting Ui, Parser, TaskList and the Commands classes.

Add A-Packages: Organize into Packages

a8f1ced

Working directory is very cluttered. Put the files into different packages.

Add A-JUnit: Add JUnit Tests

0e6eea6

Add JUnit for testing code. Added methods to test methods in AddCommand, DeleteCommand and ExitCommand classes.

Add A-JavaDoc: JavaDoc

1ac33a5

Added JavaDocs to Commands classes and Duke. JavaDocs helps external users to understand our code better.

Add A-CodingStandard: Follow the Coding Standard

5047c5a

Tweak the code to comply with the SE-EDU coding standard.

Add Level-9: Find

dedfad6

Give users a way to find a task by searching for a keyword.

Merge branch 'branch-A-JavaDoc' into master

49aee9b

Add Level-9: Find

a2753c7

Missed out the FindCommand class in the previous commit.

Merge branch 'branch-CodingStandard' into master

e6bfe61

Merge branch 'branch-Level-9' into master

cc32f6f

Merge remote-tracking branch 'origin/add-gradle-support' into master

682c175

Add A-Gradle: Use Gradle

8ba3665

Automate project builds using Gradle. Gradle can run Unit tests, as well as run the Duke program.

Merge branch 'branch-A-Gradle' into master

ea71192

Add A-CheckStyle: Use CheckStyle

c24708b

To detect coding style violations.

Merge branch 'branch-A-CheckStyle' into master

04b40fb

Add Level-10: GUI

a9d8ece

Simple GUI implemented for Duke.

Add Level-10: Refactor GUI using fxml

b6c68a2

Implemented GUI using fxml.

Zhang-Yunjie reviewed Sep 2, 2020

View reviewed changes

hanweic53 added 3 commits September 2, 2020 18:42

Improve GUI

54c115d

Merge branch 'branch-Level-10' into master

7ee400a

Add tag for A-Gradle

e51dad7

To satisfy the iP Progress Dashboard. Something went wrong with the previous A-Gradle tagging.

xuey0ng reviewed Sep 2, 2020

View reviewed changes

hanweic53 and others added 10 commits September 5, 2020 16:26

Improve GUI and repackage classes

80c2337

Add A-Assertions: Use Assertions

71785e5

Wrote assumptions that should hold at various points in the code.

Add A-CodeQuality: Improve Code Quality

de4ec58

Examine code and refactor to improve code quality.

Merge pull request #1 from hanweic53/branch-A-Assertions

4510abb

Add A-Assertions: Use Assertions

Merge branch 'master' into branch-A-CodeQuality

dd04462

Merge pull request #2 from hanweic53/branch-A-CodeQuality

9aa5f23

Add A-CodeQuality

Add A-CI: Set up CI

b6c1c19

Use Continuous Integration.

Refactor code

8be3d5a

Futher improvements on code quality.

Add C-Tagging

f1cb354

Allows tagging of tasks.

Merge branch 'branch-C-Tagging' into master

805a6a2

HynRidge reviewed Sep 10, 2020

View reviewed changes

hanweic53 and others added 14 commits September 10, 2020 23:58

Improve Tagging functions

866f9ce

Add A-BetterGui: Better Gui and refactor code

95ce6b0

Add A-UserGuide: User Guide

a8f76c4

Set theme jekyll-theme-slate

ee04d5c

Add TagList: Improve Tagging functionality

ab7bd5b

Set theme jekyll-theme-slate

db75593

Merge branch 'master' of https://github.com/hanweic53/ip into master

561b1f5

Set theme jekyll-theme-merlot

7458b5d

Set theme jekyll-theme-modernist

be2c655

Edit README.md

a6cfa65

Edit README.md

e1dae22

Edit Duke's welcome message

c15e87a

Include links in README

e828123

Update README.md

8f2020b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cheak Han Wei] iP #154

[Cheak Han Wei] iP #154

hanweic53 commented Aug 22, 2020

Zhang-Yunjie left a comment

Zhang-Yunjie Sep 2, 2020

Zhang-Yunjie Sep 2, 2020

Zhang-Yunjie Sep 2, 2020

Zhang-Yunjie Sep 2, 2020

xuey0ng left a comment •

edited

xuey0ng Sep 2, 2020

xuey0ng Sep 2, 2020

HynRidge left a comment

[Cheak Han Wei] iP #154

Are you sure you want to change the base?

[Cheak Han Wei] iP #154

Conversation

hanweic53 commented Aug 22, 2020

Zhang-Yunjie left a comment

Choose a reason for hiding this comment

Zhang-Yunjie Sep 2, 2020

Choose a reason for hiding this comment

Zhang-Yunjie Sep 2, 2020

Choose a reason for hiding this comment

Zhang-Yunjie Sep 2, 2020

Choose a reason for hiding this comment

Zhang-Yunjie Sep 2, 2020

Choose a reason for hiding this comment

xuey0ng left a comment • edited

Choose a reason for hiding this comment

xuey0ng Sep 2, 2020

Choose a reason for hiding this comment

xuey0ng Sep 2, 2020

Choose a reason for hiding this comment

HynRidge left a comment

Choose a reason for hiding this comment

xuey0ng left a comment •

edited