Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sean Lum] iP #162

Open
wants to merge 128 commits into
base: master
Choose a base branch
from
Open

[Sean Lum] iP #162

wants to merge 128 commits into from

Conversation

seanjyjy
Copy link

Add the ability to add, delete and list out tasks
Added text UI testing

@seanjyjy seanjyjy changed the title iP- week2 [Sean Lum] iP Aug 22, 2020
keanecjy
keanecjy reviewed Sep 17, 2020
View reviewed changes
Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clean and free of errors. Greate use of Junit to run multiple tests

src/main/java/duke/commands/Command.java
*
* @param tasks the task object containing the list of task.
*/
public String printNumTask(TaskList tasks) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No return statement for this method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elgoh Elgoh Elgoh left review comments

@XIA-LIYI XIA-LIYI XIA-LIYI left review comments

@keanecjy keanecjy keanecjy left review comments

@kaichaoang kaichaoang kaichaoang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@seanjyjy @Elgoh @XIA-LIYI @keanecjy @kaichaoang