[Tran Gia Phong] ip #189

PhongTran98 · 2020-08-23T02:58:07Z

No description provided.

Implement a skeletal version of Duke that starts by greeting the user, simply echos commands entered by the user, and exits when the user types bye.

Add the ability to store whatever text entered by the user and display them back to the user when requested.

Add the ability to mark tasks as done.

Add support for tracking three types of tasks: ToDos, Deadlines and Events

Teach Duke to deal with errors such as incorrect inputs entered by the user.

Add support for deleting tasks from the list.

…en calling DELETE and DONE command with out-of-range parameters

…of-range parameters

… Task class

IsaacTin

I think generally ok just need to add in some Javadocs and new lines and rearrange import statements. Nice Job!

IsaacTin · 2020-08-31T07:05:39Z

src/main/java/duke/Duke.java

+                    + "tasks list: " + taskList;
+        }
+    }
+


Should there be a JavaDoc Comment here?

IsaacTin · 2020-08-31T07:06:17Z

src/main/java/duke/Duke.java

+        while (!input.equals("bye"));
+        Ui.close();
+    }
+


Should there be a JavaDoc Comment here?

IsaacTin · 2020-08-31T07:07:28Z

src/main/java/duke/Launcher.java

+    public static void main(String[] args) {
+        Application.launch(Main.class, args);
+    }
+}


I think you might want to add newline at end of file

IsaacTin · 2020-08-31T07:11:04Z

src/main/java/duke/Main.java

+            e.printStackTrace();
+        }
+    }
+}


Perhaps also adding a newline at the end of file would be good?

IsaacTin · 2020-08-31T07:11:49Z

src/main/java/duke/MainWindow.java

+        );
+        userInput.clear();
+    }
+}


Perhaps also adding a newline at the end of file would be good?
The newline issue seems to be prevalent among other files, so perhaps it might be good to go about adding them to all the files.

IsaacTin · 2020-08-31T07:28:54Z

src/test/java/misc/ParserTest.java

@@ -0,0 +1,28 @@
+package misc;
+


Should the import statements be arranged this way?

IsaacTin · 2020-08-31T07:29:35Z

src/test/java/misc/ParserTest.java

+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class ParserTest {


Should there be a Javadoc comment here?

IsaacTin · 2020-08-31T07:29:53Z

src/test/java/misc/ParserTest.java

+        List<String> expected = new ArrayList<>(Arrays.asList("deadline", "read book", "21/12/2012 1900", "0"));
+        assertEquals(expected, actual);
+    }
+


Should there be a Javadoc comment here?

IsaacTin · 2020-08-31T07:30:34Z

src/test/java/task/DeadlineTest.java

@@ -0,0 +1,19 @@
+package task;
+


Should the import statements be arranged this way?

IsaacTin · 2020-08-31T07:30:52Z

src/test/java/task/DeadlineTest.java

+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class DeadlineTest {
+


Should there be a Javadoc comment here?

chiabs

Awesome clean code! I was really impressed and learned a lot. I couldn't really find anything to correct.

chiabs · 2020-09-01T17:07:55Z

src/main/java/duke/Duke.java

+    }
+
+    /**
+     * Run the program.


Should this be Runs instead of Run?

chiabs · 2020-09-01T17:14:37Z

src/main/java/duke/task/Task.java

+     * Create a task with a title and its optional datetime
+     *
+     * @param description the title of the task
+     * @param time        the time of the task


Did you accidentally leave a space here between "time" and "the"?

Refactor code

Add assertions

damithc and others added 30 commits July 23, 2020 23:27

Add Gradle support

3b19ba1

add Level-1

0c96d1e

Implement a skeletal version of Duke that starts by greeting the user, simply echos commands entered by the user, and exits when the user types bye.

Add Level-2

5ae8498

Add the ability to store whatever text entered by the user and display them back to the user when requested.

Add Level-3

5aeace8

Add the ability to mark tasks as done.

Add Level-4

a03360e

Add support for tracking three types of tasks: ToDos, Deadlines and Events

Enable automated UI testing

3ceb208

Add level 5

8aa8721

Teach Duke to deal with errors such as incorrect inputs entered by the user.

Add level 6

ff536bf

Add support for deleting tasks from the list.

Use Enum for commands

c7c5344

update automated testing for latter levels & fix incorrect reponse wh…

01abbdb

…en calling DELETE and DONE command with out-of-range parameters

fix incorrect response when calling DELETE and DONE command with out-…

05300f6

…of-range parameters

Migrate static methods in Task class intoa new Tasks class

9eb186a

Update automated UI testing

1fd223f

Migrate code for adding new task from Duke class to Tasks class

cd4c564

Add Level-7

4f8a0e3

Add Level-8

2a346bf

Fix conflict between Level-7 and Level-8

aa13639

Use more OOP

ac4b9f3

Refactor further to adhere OOP principles

41eeca4

Group classes into packages

e51e83c

Add some tests for Parser and Deadline class

56f5c73

Adjust access modifiers to public for subclasses of Command class and…

3b3b362

… Task class

Add Java Doc

1b3a245

Reformat code according to coding standard

7481b6d

Add level 9

1f9dfcb

Merge branch 'branch-A-JavaDoc'

338c723

Merge branch 'branch-A-Coding-Standard'

fdff8d7

Merge branch 'branch-Level-9'

aa06067

Merge remote-tracking branch 'origin/add-gradle-support'

b0c0bfe

Add gradle

6741a46

PhongTran98 added 2 commits August 30, 2020 01:11

Add checkstyle config & fix most of checkstyle warning

1dec39b

Add Level 10

8dbc599

IsaacTin reviewed Aug 31, 2020

View reviewed changes

chiabs reviewed Sep 1, 2020

View reviewed changes

PhongTran98 and others added 14 commits September 6, 2020 12:46

refactor code

1f488aa

Add assertion

80712ed

Merge pull request #1 from PhongTran98/branch-A-CodeQuality

f95c0c3

Refactor code

Merge branch 'master' into branch-A-Assertions

3fbf230

Merge pull request #2 from PhongTran98/branch-A-Assertions

dea7d30

Add assertions

Set up CI

406532f

Refactor parser

ccb9e28

Add C-MassOps

96e9b24

Improve GUI

7ae28d9

Add the app's title and the UG

52b73d6

Set theme jekyll-theme-slate

03766a4

Fix README.md

8d19808

Merge branch 'master' of github.com:PhongTran98/ip

40b6303

Fix DONE command and BYE command

f12ff1d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tran Gia Phong] ip #189

[Tran Gia Phong] ip #189

PhongTran98 commented Aug 23, 2020

IsaacTin left a comment

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

chiabs left a comment

chiabs Sep 1, 2020

chiabs Sep 1, 2020


		import static org.junit.jupiter.api.Assertions.assertEquals;

		public class ParserTest {

		import static org.junit.jupiter.api.Assertions.assertEquals;

		public class DeadlineTest {

[Tran Gia Phong] ip #189

Are you sure you want to change the base?

[Tran Gia Phong] ip #189

Conversation

PhongTran98 commented Aug 23, 2020

IsaacTin left a comment

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 • edited

Choose a reason for hiding this comment

chiabs left a comment

Choose a reason for hiding this comment

chiabs Sep 1, 2020

Choose a reason for hiding this comment

chiabs Sep 1, 2020

Choose a reason for hiding this comment

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited

IsaacTin Aug 31, 2020 •

edited