Add more feature to the bot #199
Conversation
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
Maybe it is better to name the object with another better name that describes the object better?
| /** | ||
| * Check if the current command is an exit command | ||
| **/ | ||
| public abstract boolean isExit(); |
There was a problem hiding this comment.
Perhaps it is better to set isExit as a boolean attribute?
| public String toString() { | ||
| return isDone | ||
| ? "[D][✓] " + this.getName() + " (by: " | ||
| + this.deadline.format(DateTimeFormatter.ofPattern("MMM d yyyy HHmm")) + ")" |
There was a problem hiding this comment.
I think it will be better to indent four spaces before the '+' as this is break of a statement.
| } | ||
| } | ||
|
|
||
| private static int decideIndexDelete(String word) throws MissingSpecifiedDeleteError { |
There was a problem hiding this comment.
Maybe it is better to name the method as decideDeleteIndex as the index is the most concerned word.
| /** | ||
| * Initializes AddCommand class | ||
| * | ||
| * @param command |
There was a problem hiding this comment.
I think the recommended JavaDoc for methods with parameters is that you describe the parameter in a one-liner, so maybe "@param command command of user" would be better!
| /** | ||
| * Initializes DeleteCommand | ||
| * | ||
| * @param command |
There was a problem hiding this comment.
As above, here you could include the description of your parameter
| * Load all the tasks from the save file to ArrayList<Task> | ||
| **/ | ||
| public ArrayList<Task> load() throws DukeException { | ||
| ArrayList<Task> temp = new ArrayList<>(); |
There was a problem hiding this comment.
I think according to coding standards they recommended that we put plural form for collections such as lists, so here maybe 'tasks' would be a better variable name!
| } | ||
| } else { | ||
| try { | ||
| String currname = name.substring(6); |
There was a problem hiding this comment.
I think according to coding standards it should be currName and not currname!
Add assertions
Refine code quality
Add detect duplicates feature
Add some features and converting the project into more OOP based.
Also add javadocs and follow the coding standard