[Wen Junhua] iP #20
[Wen Junhua] iP #20
Conversation
Changelog: 1. Changed flavour of duke 2. Added correct Expected output 3. Added inputs into the testcases
Change log: 1. Added Completed boolean 2. Added isDone, markDone, markUnDone and getStatusIcon methods
Change log: 1. Added size method 2. Added markDone method
Change log: 1. Added Checks for the command
This reverts commit d842691.
Updated Duke to level-4
| @@ -0,0 +1,57 @@ | |||
| package ultron.tasks; | |||
|
|
|||
| public final class Todo extends Task { | |||
There was a problem hiding this comment.
Is there a need to declare Todo as a final class? I think there are still some possibilities to extend this class though we might not need it in our iP
There was a problem hiding this comment.
When the extension comes, I can just remove the final after that and extend from there?
What I was thinking was that everything extends from the abstract class Task.
If there are other similar classes as todo we can all group them under todo or modify todo to accommodate other functions
| Pattern.compile("^(.*) (/at) (.*)$"); | ||
| /** Stores the date format regex.*/ | ||
| private static final DateFormat DATE_FORMAT = | ||
| new SimpleDateFormat("dd-MM-yyyy HHmm"); |
There was a problem hiding this comment.
Would it be simpler if you use LocalDateTime here?
There was a problem hiding this comment.
Yes, that might be true. Might edit in a future commit haha. Thanks for letting me know.
|
|
||
| //Throw a Duke exception | ||
| throw new UltronException(command, | ||
| ExceptionType.INVALID_COMMAND); |
There was a problem hiding this comment.
Indentation for wrapped lines should be 8 spaces.
Update JavaDocs for TaskCommand Use of lambdas present in Enum already
Update FindCommand to use streams
Add workflow for Gradle
Update help message to show find
Refactor Parser
No description provided.