Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rui Feng] iP #210

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

[Rui Feng] iP #210

wants to merge 45 commits into from

Conversation

RuiFengg
Copy link

No description provided.

damithc and others added 24 commits July 23, 2020 23:27
Add Gradle support
3b19ba1
@RuiFengg
skeletal layout
8087fe6
@RuiFengg
Greet, Echo, Exit
8104e21
@RuiFengg
Add, List
3b781db
@RuiFengg
Mark as Done
71f3015
@RuiFengg
Todos, Events, Deadlines
c5e5501
@RuiFengg
adding unstaged files
db752af
@RuiFengg
A-TextUiTesting
043d4bd
@RuiFengg
A-Exceptions
d66b4d8
@RuiFengg
Delete
78f5013
@RuiFengg
Add read write task list to file functionality
4c3ba21
@RuiFengg
Add save functionality
3d818ed
@RuiFengg
Store timings as LocalDateTime objects
328d351
@RuiFengg
Refactor code to extract out related classes
5331cfc
@RuiFengg
Orgainze into packages
d14540f
@RuiFengg
Add JUnit tests
fd76b08
@RuiFengg
Add JavaDoc comments
71dbf6d
@RuiFengg
Follow coding standards
df9f61a
@RuiFengg
Add find by keyword functionality
5bc9d17
@RuiFengg
Merge branch-A-CodingStandard into master
797bbd8
@RuiFengg
Merge branch-Level-9 into master
4ca722b
@RuiFengg
Merge remote-tracking branch 'origin/add-gradle-support' into A-Gradle
3927670
@RuiFengg
Add Gradle for running and JUnit tests
2ca9733
@RuiFengg
Use Checkstyle
f1178f6
Cedo8
Cedo8 reviewed Aug 31, 2020
View reviewed changes
Copy link

@Cedo8 Cedo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I feel that your code is well abstracted, clean and adheres to the Java coding standards. Just a few nits to rectify!

src/main/java/duke/Duke.java Show resolved Hide resolved
src/main/java/duke/commands/AddCommand.java Show resolved Hide resolved
src/main/java/duke/commands/AddCommand.java Show resolved Hide resolved
src/main/java/duke/commands/FindCommand.java Outdated Show resolved Hide resolved
src/main/java/duke/parser/Parser.java Show resolved Hide resolved
src/main/java/duke/task/Task.java Show resolved Hide resolved
src/main/java/duke/task/Task.java Outdated Show resolved Hide resolved
src/main/java/duke/task/TaskList.java Show resolved Hide resolved
src/main/java/duke/task/TaskList.java Show resolved Hide resolved
src/test/java/duke/task/TaskTest.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cedo8 Cedo8 Cedo8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RuiFengg @Cedo8