[Wang Mo] iP #236
Open
[Wang Mo] iP #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include testing for delete and error-handling(Level 5 and Level 6)
The past tasks added or deleted are not saved in a file before. It should be saved in a file for retrieval and the file should be updated after each operation, so that data would be remembered after the operations. Let's create a Storage class to store the data related to tasks and enable write to the file and read data from the file. This is done so that the user could have easy reference to tasks they added before.
The classes are not yet refactored using more OOP concepts. This need to change since such code is harder to maintain. Let's extract the classes Ui, Storage, Parser, TaskList and Command classes. This will make the logic looks more clear by using more OOP concepts.
Tests are not present to test the behavior of the code. Junit tests should be added to test the behavior of the code since it helps to spot errors. Let's add Junit tests. This allows the testing of methods become facilitated.
Currently there is no javadoc written. Javadoc is important as it helps to explain the usages of each method and class. Let's write Javadoc documents for more than half of the public methods/classes.
The program does not have GUI yet. GUI is required to have a good user interface. Let's implement GUI. A GUI implemented can allow users to use the program easily.
moyj01
reviewed
Sep 2, 2020
moyj01
reviewed
Sep 2, 2020
Implement A-Assertions
Implement A-CodeQuality
Implement C-DetectDuplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.