[Pang Wai Kye] iP #24

pangpuncake · 2020-08-20T08:17:34Z

No description provided.

…and FileHandler.java

Add save file capabilities and minor improvements

Merge which adds Regex handling, modifying functions and classes to accomodate LocalDate class

…andler -> Storage, DukeList -> TaskList. Improve regex expression for Storage. Abstract contents of Duke main to run() function and various classes.

…ask, under one main package duke.

…ges. Improve regex expression in Parser.

…on the words in the description.

# Conflicts: # src/main/java/duke/command/Parser.java # src/main/java/duke/storage/Storage.java # src/main/java/duke/task/Task.java # src/main/java/duke/task/Todo.java

# Conflicts: # src/main/java/duke/task/TaskList.java

…nt after merge of the 3 branches.

HCY123902

Looks good in general. There are some small problems that need to be addressed.

HCY123902 · 2020-08-31T04:30:50Z

src/main/java/duke/command/Parser.java

+
+    /**
+     * Checks if the command to exit has been issued
+     * @return True if 'bye' command has been issued, False otherwise.


Will it be better if there can be a new line between the description of the method and the description of the parameter and the description of the result?

HCY123902 · 2020-08-31T04:31:49Z

src/main/java/duke/command/Parser.java

+    /**
+     * The function that processes the incoming command and executes different
+     * functions depending on the command.
+     * @param command String command provided by the user.


Will it be better if there can be a new line between the description of the method and the description of the parameter and the description of the result? I have noticed similar problems in several other places.

HCY123902 · 2020-08-31T04:34:45Z

src/main/java/duke/command/Parser.java

+            case ("todo"):
+            case ("deadline"):
+            case ("event"):
+                return this.processTask(com, task, date);


Will it be better to include a default section here?

HCY123902 · 2020-08-31T04:37:14Z

src/main/java/duke/command/Parser.java

+     * @return String result of the provided command.
+     * @throws DukeException A custom Exception that carries a message for the user if thrown.
+     */
+    public String processCommand(String command) throws DukeException {


Will it be better to give a more descriptive name for the method, such as identifying the command elements and evaluating the command?

HCY123902 · 2020-08-31T04:37:48Z

src/main/java/duke/command/Parser.java

+        if (command.equals("list")) {
+            return this.list.toString();
+        }
+        if (command.equals("hello")) {


Will it be better to include the keyword else here?

As mentioned by HCY123902, could this have been a series of if-else statements instead?

HCY123902 · 2020-08-31T04:43:44Z

src/main/java/duke/storage/Storage.java

+     * Checks if the /data directory exists.
+     * @return True if it exists, False otherwise.
+     */
+    private boolean dirExists() {


Will it be better to give a more descriptive name to the method, such as the name is directory present?

HCY123902 · 2020-08-31T04:44:10Z

src/main/java/duke/storage/Storage.java

+     * Checks if the /data/list.txt file exists.
+     * @return True if it exists, False otherwise.
+     */
+    private boolean fileExists() {


Will it be better to give a more descriptive name to the method, such as the name is file present?

HCY123902 · 2020-08-31T04:44:57Z

src/main/java/duke/storage/Storage.java

+     * Gets the TaskList that has been saved in list.txt File.
+     * @return TaskList.
+     */
+    public TaskList getList() {


Will it be better to give a more descriptive name to the method and include the sources of the task list in the name?

HCY123902 · 2020-08-31T04:45:37Z

src/main/java/duke/task/Event.java

+ */
+public class Event extends Task {
+
+    LocalDate date;


Will it be better to give an accessor to the variable here?

HCY123902 · 2020-08-31T04:50:25Z

src/main/java/duke/command/Parser.java

+                    "delete <index> - deletes the specified task from the list";
+        }
+        if (matcher.find()) {
+            String com = matcher.group(1);


Will it be better to give a more descriptive name and include the information on which part of the command it represents?

… and rename test files.

…of Duke into the GUI.

…rove GUI. In UI class, showWelcome() now returns a String.

kerkpy

Largely good style!

kerkpy · 2020-09-01T17:05:49Z

src/main/java/duke/command/Parser.java

+        if (command.equals("list")) {
+            return this.list.toString();
+        }
+        if (command.equals("hello")) {


As mentioned by HCY123902, could this have been a series of if-else statements instead?

kerkpy · 2020-09-01T17:12:36Z

src/main/java/duke/command/Parser.java

+
+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeParseException;


Should there be a line break between the import statements here?

kerkpy · 2020-09-01T17:14:43Z

src/main/java/duke/command/Parser.java

+            return "Hi! I'm Duke! Pleasure to meet you :)";
+        }
+        if (command.equals("bye")) {
+            this.isExit = true;


is isExit, rather than this.isExit, sufficient?

kerkpy · 2020-09-01T17:16:59Z

src/main/java/duke/task/TaskList.java

+     * @return String result that describes the item added
+     * if successful.
+     */
+    public String addItem(Task item) {


Should the method be renamed as addTask instead to be consistent?

Yes, I totally agree with kerkpy's input

kerkpy · 2020-09-01T17:17:38Z

src/main/java/duke/task/TaskList.java

+     * @return String result that describes the deleted Task
+     * if successful.
+     */
+    public String deleteItem(int index) {


As per addItem, could this be deleteTask instead of deleteItem

HynRidge

It would be better if you could do more abstraction per se, but all things are good. Just that there are some naming that could cause confussion.

HynRidge · 2020-09-03T05:51:57Z

src/main/java/duke/command/Parser.java

+     * @return String result of the function executed.
+     * @throws DukeException A custom Exception that carries a message for the user if thrown.
+     */
+    private String processTask(String com, String task, String date) throws DukeException {


Hi, I think the naming of your paramaters could be made more clearer, such that com --> command. Sometimes it is just confusing to read a contracted or shortened word.

HynRidge · 2020-09-03T05:53:43Z

src/main/java/duke/storage/Storage.java

+    }
+
+    /**
+     * Private method that gets the list.txt file if present, else a new


The comments seems good and it would be better if it could start with verbs instead following the Coding Standard

HynRidge · 2020-09-03T05:54:42Z

src/main/java/duke/storage/Storage.java

+            while (scanner.hasNextLine()) {
+                Matcher matcher = pattern.matcher(scanner.nextLine());
+                if (matcher.find()) {
+                    boolean done = matcher.group(2).equals("1");


The naming would be better to set as isDone instead of done, as it is a boolean data type. It is just so that the variable is more descriptive

HynRidge · 2020-09-03T05:56:06Z

src/main/java/duke/task/Deadline.java

+     * @param task The description of the task.
+     * @param date The LocalDate object that specifies the due date.
+     */
+    public Deadline(String task, LocalDate date) {


The naming for task description would be better to be named taskDescription rather than just task.

HynRidge · 2020-09-03T05:57:18Z

src/main/java/duke/task/TaskList.java

+ */
+public class TaskList {
+
+    private List<Task> list;


The naming would be better set as lists rather than list. It is just so that it is more descriptive

HynRidge · 2020-09-03T05:57:47Z

src/main/java/duke/task/TaskList.java

+     * @return String result that describes the item added
+     * if successful.
+     */
+    public String addItem(Task item) {


Yes, I totally agree with kerkpy's input

…d in error handling.

…s DukeException upon error in creation of list.txt save file.

A - Assertions

A - CodeQuality

…ble to add notes yet.

…e and "note" functionality which allows users to write the note. Minor bug fixes in Parser to prevent non-numbered inputs for index related commands.

…xist in the list results in program failure.

damithc and others added 8 commits July 23, 2020 23:27

Add Gradle support

3b19ba1

Level - 1

d87f0e0

Level - 2

9e7c894

Level - 3

f1f8840

Level - 4

e208477

A - TextUiTesting

3db75b1

Level - 5

db75379

Level - 6

650ea03

pangpuncake changed the title ~~[Wai Kye] iP~~ [Pang Wai Kye] iP Aug 20, 2020

“pangpuncake” added 18 commits August 20, 2020 16:55

Level - 6 : Used Switch statements in Command.java for cleaner code

4a2c97f

Level - 6 : Add "undo" functionality to mark as undone.

e79dda0

Level - 7: Create initial working foundation

4588530

Level - 8: Use regex to handle input, modify methods in Command.java …

0b5ed30

…and FileHandler.java

Merge branch 'branch-Level-7'

4893e20

Add save file capabilities and minor improvements

Merge branch 'branch-Level-8'

45a6cc5

Merge which adds Regex handling, modifying functions and classes to accomodate LocalDate class

A - MoreOOP: Add Ui class, refactor names of Command -> Parser, FileH…

69a1f93

…andler -> Storage, DukeList -> TaskList. Improve regex expression for Storage. Abstract contents of Duke main to run() function and various classes.

A - Packages: Package to 3 different subpackages, command, storage, t…

e50ee67

…ask, under one main package duke.

A - JUnit: Add basic JUnit tests for duke.Command and duke.Task packa…

4539510

…ges. Improve regex expression in Parser.

A - Jar: Add 'help' command

9e814f2

A - JavaDoc: Create headers and method documentation for all classes.

c5da1f2

A - CodingStandard: Reformat to match coding standard.

3a78120

Level - 9: Add 'find' command which allows users to find tasks based …

7d7a218

…on the words in the description.

Update .gitignore to omit META-INF and src/main/data

79f36e3

Merge branch 'branch-A-JavaDoc'

3f03b68

Merge branch 'branch-A-CodingStandard'

4e07b28

# Conflicts: # src/main/java/duke/command/Parser.java # src/main/java/duke/storage/Storage.java # src/main/java/duke/task/Task.java # src/main/java/duke/task/Todo.java

Merge branch 'branch-Level-9'

ca812e3

# Conflicts: # src/main/java/duke/task/TaskList.java

Add method message for 'findWord()' in TaskList, as it was only prese…

5e40bf0

…nt after merge of the 3 branches.

HCY123902 reviewed Aug 31, 2020

View reviewed changes

“pangpuncake” added 2 commits August 31, 2020 15:56

Merge branch 'add-gradle-support'

476e5ed

A - CheckStyle: Fix styling issues in all files. Rename test packages…

23e203a

… and rename test files.

“pangpuncake” added 4 commits August 31, 2020 17:35

Level - 10: Add javafx to the project. Create simple Hello World GUI.

9da1181

Level - 10: Improve GUI of Duke and allow for original functionality …

9d870ca

…of Duke into the GUI.

Level - 10: Update processCommand to update list.txt directly and imp…

9eed66a

…rove GUI. In UI class, showWelcome() now returns a String.

Merge branch 'branch-Level-10'

89b144e

kerkpy reviewed Sep 1, 2020

View reviewed changes

Level - 10: Add border to DialogBox.

29ea088

HynRidge reviewed Sep 3, 2020

View reviewed changes

“pangpuncake” and others added 15 commits September 5, 2020 16:53

Update if statements to else if statements in Parser.

ae1e867

A - Assertions: Add assert keywords to different areas of logic to ai…

8d63adb

…d in error handling.

A - CodeQuality: Refactor code using guard clauses. Storage now throw…

2df7559

…s DukeException upon error in creation of list.txt save file.

Merge pull request #1 from pangpuncake/branch-A-Assertions

e1731c7

A - Assertions

Merge branch 'master' into branch-A-CodeQuality

0370a04

Merge pull request #2 from pangpuncake/branch-A-CodeQuality

823d15b

A - CodeQuality

Resolve minor errors from merge conflicts.

31be0e3

Fix formatting errors after merging of PR.

4d45caa

D - Notes: Add basic note functionality that only has null notes. Una…

45af356

…ble to add notes yet.

D - Notes: Add "view" functionality to see the full task with its not…

bdf1f7b

…e and "note" functionality which allows users to write the note. Minor bug fixes in Parser to prevent non-numbered inputs for index related commands.

D - Notes: Minor bug fix where choosing a task number that does not e…

1cf977a

…xist in the list results in program failure.

A - BetterGui: Improve GUI

b273605

A - UserGuide: Add User Guide and Minor bug fixes.

3a20d14

Add DukeImage.png to README.md

c910cad

Update README.md

f7fc1a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Pang Wai Kye] iP #24

[Pang Wai Kye] iP #24

pangpuncake commented Aug 20, 2020

HCY123902 left a comment

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

kerkpy Sep 1, 2020

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

HCY123902 Aug 31, 2020

kerkpy left a comment

kerkpy Sep 1, 2020

kerkpy Sep 1, 2020

kerkpy Sep 1, 2020

kerkpy Sep 1, 2020

HynRidge Sep 3, 2020

kerkpy Sep 1, 2020

HynRidge left a comment •

edited

HynRidge Sep 3, 2020

HynRidge Sep 3, 2020

HynRidge Sep 3, 2020

HynRidge Sep 3, 2020

HynRidge Sep 3, 2020

HynRidge Sep 3, 2020

[Pang Wai Kye] iP #24

Are you sure you want to change the base?

[Pang Wai Kye] iP #24

Conversation

pangpuncake commented Aug 20, 2020

HCY123902 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerkpy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HynRidge left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HynRidge left a comment •

edited