[Ng Si Qiang] iP #252
[Ng Si Qiang] iP #252
Conversation
| /** | ||
| * Contains all the saved tasks in a List form | ||
| */ | ||
| public class TaskList { |
There was a problem hiding this comment.
Could consider if TaskList should be placed inside the task package or along side the duckie class
| public class DuckieTest { | ||
| @Test | ||
| public void dummyTest() { | ||
| assertEquals(2, 2); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could consider getting rid of this test class since it actually is just a dummy test that doesn't really test any of the features in your actual code
|
|
||
| import duckie.exception.DuckieException; | ||
|
|
||
| public class TaskListTest { |
There was a problem hiding this comment.
Very comprehensive testing of tasklist. 👍
| import duckie.task.Deadline; | ||
| import duckie.task.Event; | ||
| import duckie.task.Task; | ||
| import duckie.task.Todo; |
There was a problem hiding this comment.
I like how you arrange your import statements tidy and in order!
src/main/java/duckie/Storage.java
Outdated
| if (!duckieFile.exists()) { | ||
| File dir = new File(duckieFile.getParent()); | ||
| if (!dir.exists()) { | ||
| if (dir.mkdirs() && duckieFile.createNewFile()) { |
There was a problem hiding this comment.
Perhaps you may consider avoid deep nesting (up to 3 levels of indentation) here to make the code more readable.
src/main/java/duckie/task/Task.java
Outdated
| * Return the type of a Task | ||
| * @return null | ||
| */ | ||
| public String getType() { |
There was a problem hiding this comment.
Perhaps you may consider change Task to an abstract class so that the implementation of getType(), getDate() can added later in child classes, instead of returning null value.
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Perhaps you can consider get rid of so many empty lines.
Add assertions at some methods
Improve code quality
No description provided.