[Rachel Gina] iP #254
[Rachel Gina] iP #254
Conversation
…ed sized array - size of 100)
…ed array of size 100)
…tracking the three types of tasks
…changes. Load the data from the hard disk when the programme starts up.
…ted to output of dd MMM yyyy)
…changes. Load the data from the hard disk when bot starts up.
…tput (dd-MM-yyyy to dd MMM yyyy) # Conflicts: # src/Deadline.java # src/Duke.java
…P), add continuation of bot after exceptions caught
…stencies for exceptions thrown
There was a problem hiding this comment.
Overall, I feel that you did an amazing job in following the coding standards! Naming wise, I think it might be better if you can give a more meaningful and clearer name to the variables rather than just letters like s, e and etc... But still, I can understand what the variables mean so I didn't comment on it.
| private void addToTaskList(String[] s, ArrayList<Task> tasks) { | ||
| boolean isDone = s[2].equals("\u2713"); | ||
| switch (s[0]) { | ||
| case "T": |
There was a problem hiding this comment.
There should be no indentation for case clauses.
| private void addToTaskList(String[] s, ArrayList<Task> tasks) { | ||
| boolean isDone = s[2].equals("\u2713"); | ||
| switch (s[0]) { | ||
| case "T": |
There was a problem hiding this comment.
There should be no indentation for case clauses for CS2103 convention.
src/main/java/duke/ui/Ui.java
Outdated
|
|
||
| public class Ui { | ||
| private Scanner userInput; | ||
| private String lastError; |
| import duke.task.Deadline; | ||
| import duke.task.Event; | ||
| import duke.task.Task; | ||
| import duke.task.Todo; |
There was a problem hiding this comment.
I like how the import statements are organised based on their association 👍
| @@ -0,0 +1,119 @@ | |||
| package duke.ui; | |||
| import duke.logic.TaskList; | |||
There was a problem hiding this comment.
I notice other files have the line to separate package and import statements except for this. Would be good for readability to standardize according to src/main/java/duke/logic/Storage.java
There was a problem hiding this comment.
It could be the files that were written earlier that result in the inconsistent ordering of import statements.
Add help command to Moco to list current commands that are valid
Use Assertions
No description provided.