[Yong Kang] iP #283
[Yong Kang] iP #283
Conversation
src/main/java/Parser.java
Outdated
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| public class Parser { | ||
|
|
There was a problem hiding this comment.
I think public methods should have comments?
src/main/java/Parser.java
Outdated
| String[] parsed = input.split(" ", 2); | ||
| String keyword = parsed[0]; | ||
| String body = ""; | ||
| if (parsed.length > 1) body = parsed[1]; |
There was a problem hiding this comment.
I think if else statements should have curly brace?
src/main/java/Storage.java
Outdated
| file = new File(filepath); | ||
| } | ||
|
|
||
| public ArrayList<Task> load() throws FileNotFoundException, DukeException { |
There was a problem hiding this comment.
Would a more descriptive method name be more suitable here?
src/main/java/Storage.java
Outdated
| } | ||
| } | ||
|
|
||
| public void write(TaskList tasks) throws IOException { |
There was a problem hiding this comment.
Would a more descriptive method name be more suitable here? Perhaps writeFile?
src/main/java/Parser.java
Outdated
| private static String desc(String body) { | ||
| return body.split(" /", 2)[0]; | ||
| } |
There was a problem hiding this comment.
Perhaps starting the method with a verb? An example can be getDesc.
src/main/java/Parser.java
Outdated
| private static String deadline(String body) { | ||
| String time = body.split(" /by ", 2)[1]; | ||
| if (time.equals("now")) { | ||
| return LocalDate.now().format(DateTimeFormatter.ofPattern("d MMM yyyy")); | ||
| } else { | ||
| return LocalDate.parse(time).format(DateTimeFormatter.ofPattern("d MMM yyyy")); | ||
| } | ||
| } |
There was a problem hiding this comment.
Perhaps starting the method with a verb? An example can be getDeadline.
src/main/java/Parser.java
Outdated
| * @throws DukeException When user input cannot be understood. | ||
| */ | ||
| public static void parseInput(String input, Ui ui, TaskList tasks, Storage storage) throws DukeException, IOException { | ||
| String[] parsed = input.split(" ", 2); |
There was a problem hiding this comment.
I didn't know you can do this! Nice 👍
src/main/java/Parser.java
Outdated
| * @return A boolean whether input is bye. | ||
| */ | ||
| public static boolean isBye(String input){ | ||
| return input.split(" ", 2)[0].equals("bye"); |
There was a problem hiding this comment.
just a small suggestion, maybe you can mention that input.split(...)[0] is the firstWord of the input by creating a variable so it's slightly clearer!
src/main/java/TaskList.java
Outdated
| noneFound = false; | ||
| } | ||
| } | ||
| if (noneFound) ui.say("No matching tasks."); |
There was a problem hiding this comment.
I think you can add in brackets based on the coding standards, but your code is really neat!
Test commit
Merge PR Branch A code quality
Implement B-Snooze
Add JavaDoc comments
No description provided.