[Zhang Wanlin] iP #305
Open
[Zhang Wanlin] iP #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed some incomplete statements.
# Conflicts: # src/Duke.java # src/Memory.java
# Conflicts: # src/Duke.java # src/Memory.java # src/Status.java
Level-5 is featured because it has more error handling compard to previous levels. The Level-5 debugging return has an improper return when the deadline and event omit time. This mistake has been fixed with change in Operation class.
Level-6 has new feature of delete function added into the command of Duke. Simlar to Level-5 update, the improper return when deadline or event omits the time element, is carried foward to last update of Level-6. The mistake output has been fixed by changing the Operation class.
At Level-6, Duke has all the basic functions of a reminder. However, Duke cannot store all information into the hardware, which makes it meaningless if it functions as a reminder. Update is made to include the use of hardware. Now, with the use of adding event, list, done, delete, corresponding information in ./data/Duke.txt will also change accordingly.
Current stage has fulfiled all required tasks. The EditiFile class should be named as EditFile. This typo has been fixed.
For Level-7 and levels before, event and deadline tasks need to specify the respective time. However, this time can be in any words, which sometimes does not even make sense. In this level, the format of time has been formated and the user must follow the time format in order to note down the task.
* branch-Level-7: Update Level-7 Update Level-7
* branch-Level-8: Update Level-8 # Conflicts: # data/Duke.txt # src/DukeException.java # src/Exceptions.java # src/Formating.java
Currently, there are a number of classes that have different functions to serve the clients. However, some classes are too powerful and do not serve single purpose. A more OOP desgin is applied in the code to make each class to serve a single purpose. (i.e. the required Storage class is divided into WriteIn.java, ReadFile,java, EditFile.java to serve their function more explicitly).
All classes are just under src, and only the file name tells the function of this java file. This makes it not clear enough about the purpose of each class. This commit shifted all classes into different packages to clarify further about the collective function of classes.
All previous levels are fulfilled. However, there is no test method. JUnit test files are added into the ip/src/test.
Current state stops at Gradle fat jar file.
Although the function works fine in IDE When converted to jar, storage class has problem during operation. All related bugs are fixed and GUI is improved.
Assertions are added to ensure the correct logic in the operation of program.
Update A-Assertions
This commit checked the code quality and to correct the incorrect parts.
Increment A-CodeQuality
This is more on a test nature in which it is unsure if the .yml is functional.
The code has been implememted into gradle.yml file.
file .workflows is renamed as workflow and shifted to be under .github.
* commit '9d6838d81fb4f37e896da6eae572f00b8c6e7ad2': Add update in the for of update <task index> <time/detail> /to <detailToUpdate>.
Features like different chatBox colour, auto close are added.
Framworks and alignments are added
Some checkStyple is missed. This commit has fixed it.
counter of tasks is not updated this commit fixed it
removed unused import class
bugs were found in test cases. This commit fixed them
Previously the delete command cannot review correct task number. Hence readme is also corrected.
clear all is added to clear completed tasks
Features of human time description, like today morning, tomorrow night are added.
deleted some unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.